Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 577983002: PPAPI: Make empty webcam names turn in to a space. (Closed)

Created:
6 years, 3 months ago by dmichael (off chromium)
Modified:
6 years, 3 months ago
Reviewers:
teravest, ilja
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PPAPI: Make empty webcam names turn in to a space. When permission for a webcam has not yet been granted, we still allow enumerating the devices, but omit the name. Some Flash content can't deal with an empty string for the webcam name. This turns the empty string in to a space to work around the problem. BUG=408404 Committed: https://crrev.com/271b5ac015bc9eeaee9a6e14442dbb9e8ef3889d Cr-Commit-Position: refs/heads/master@{#295476}

Patch Set 1 #

Patch Set 2 : wrap in std::string constructor so types match #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/renderer/pepper/pepper_media_device_manager.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
dmichael (off chromium)
What do you think of this approach? Stupid, but simple. I verified it fixes the ...
6 years, 3 months ago (2014-09-17 17:02:07 UTC) #2
ilja
On 2014/09/17 17:02:07, dmichael wrote: > What do you think of this approach? Stupid, but ...
6 years, 3 months ago (2014-09-18 06:02:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/577983002/20001
6 years, 3 months ago (2014-09-18 15:05:10 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-18 15:05:11 UTC) #7
dmichael (off chromium)
teravest@, I need a committer review. Look OK to you?
6 years, 3 months ago (2014-09-18 15:39:05 UTC) #9
teravest
lgtm
6 years, 3 months ago (2014-09-18 15:39:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/577983002/20001
6 years, 3 months ago (2014-09-18 15:40:41 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9b91b4437fbd5c490b23f31cd67523c6396fe1a8
6 years, 3 months ago (2014-09-18 16:14:27 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 16:14:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/271b5ac015bc9eeaee9a6e14442dbb9e8ef3889d
Cr-Commit-Position: refs/heads/master@{#295476}

Powered by Google App Engine
This is Rietveld 408576698