Add time-to-network histogram considering browser side navigation

content/browser/loader/resource_dispatcher_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 
 #include <algorithm>
 #include <set>
@@ skipping 14 matching lines @@
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "content/browser/appcache/appcache_interceptor.h"
 #include "content/browser/appcache/chrome_appcache_service.h"
 #include "content/browser/cert_store_impl.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/download/download_resource_handler.h"
 #include "content/browser/download/save_file_manager.h"
 #include "content/browser/download/save_file_resource_handler.h"
 #include "content/browser/fileapi/chrome_blob_storage_context.h"
 #include "content/browser/frame_host/navigation_request_info.h"
+#include "content/browser/frame_host/navigator.h"
 #include "content/browser/loader/async_resource_handler.h"
 #include "content/browser/loader/buffered_resource_handler.h"
 #include "content/browser/loader/cross_site_resource_handler.h"
 #include "content/browser/loader/detachable_resource_handler.h"
 #include "content/browser/loader/power_save_block_resource_throttle.h"
 #include "content/browser/loader/redirect_to_file_resource_handler.h"
 #include "content/browser/loader/resource_message_filter.h"
 #include "content/browser/loader/resource_request_info_impl.h"
 #include "content/browser/loader/stream_resource_handler.h"
 #include "content/browser/loader/sync_resource_handler.h"
@@ skipping 277 matching lines @@
     DCHECK(handle);
     if (!handle)
       continue;
     // Ensure the blob and any attached shareable files survive until
     // upload completion. The |body| takes ownership of |handle|.
     const void* key = handle.get();
     body->SetUserData(key, handle.release());
   }
 }
 
+// PlzNavigate
+// This method is called in the UI thread to send the timestamp of a resource
+// request to the respective NavigatorImpl (for an UMA histogram).
+void LogResourceRequestTimeOnUI(
+    base::TimeTicks timestamp,
+    int render_process_id,
+    int render_frame_host,
+    GURL url) {

[davidben, 2014/09/19 21:52:45]

Nit: const GURL& url

[carlosk, 2014/09/23 17:02:57]

Done.

+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  RenderFrameHostImpl* host =
+      RenderFrameHostImpl::FromID(render_process_id, render_frame_host);
+  if (host != NULL) {
+    DCHECK(host->frame_tree_node()->IsMainFrame());
+    content::Navigator* navigator = host->frame_tree_node()->navigator();

[clamy, 2014/09/19 14:56:03]

content:: is unnecessary here.

[carlosk, 2014/09/23 17:02:57]

Done.

+    navigator->LogResourceRequestTime(timestamp, url);
+  }
+}
+
 }  // namespace
 
 // static
 ResourceDispatcherHost* ResourceDispatcherHost::Get() {
   return g_resource_dispatcher_host;
 }
 
 ResourceDispatcherHostImpl::ResourceDispatcherHostImpl()
     : save_file_manager_(new SaveFileManager()),
       request_id_(-1),
@@ skipping 539 matching lines @@
   }
 
   filter_ = NULL;
   return handled;
 }
 
 void ResourceDispatcherHostImpl::OnRequestResource(
     int routing_id,
     int request_id,
     const ResourceHostMsg_Request& request_data) {
+  if (request_data.resource_type == RESOURCE_TYPE_MAIN_FRAME) {
+    int child_id = filter_->child_id();

[clamy, 2014/09/19 14:56:03]

nit: you could just write filter_->child_id() in the PostTask below.

[carlosk, 2014/09/23 17:02:57]

Done.

+    BrowserThread::PostTask(
+        BrowserThread::UI,
+        FROM_HERE,
+        base::Bind(&LogResourceRequestTimeOnUI,
+                   TimeTicks::Now(),

[davidben, 2014/09/19 21:52:45]

A thought: net/ maintains a net::LoadTimingInfo which already has a
request_start in it. It's not quite the same; that measures when //net starts
processing the request so it wouldn't include, say, SafeBrowsing checks.
net::LoadTiming is on the content::ResourceResponse. I wonder if it would be
better to extract it from there. In https://codereview.chromium.org/519533002/,
it'll be available on the ResourceResponse we get back when the navigation
commits.

https://code.google.com/p/chromium/codesearch#chromium/src/net/base/load_timi...

(It would also be easy enough for NavigationURLLoader to send this variant of
request_start through its Delegate, but this one means not introducing a new
variant.)

[carlosk, 2014/09/23 17:02:57]

As discussed in yesterday's hangout I'll use this information instead of the
more convoluted way it's done now. That means that for adding the
time-to-network histogram I'll wait on the CL 
https://codereview.chromium.org/519533002/ to be submitted so that the
request_time is made available at navigation commit.

[clamy, 2014/09/23 21:54:07]

As mentioned in the bug, this is problematic as
https://codereview.chromium.org/519533002/ will only make it available for the
PlzNavigate architecture. But this TimeToNetwork histogram is mostly interesting
for the current architecture, where we should see a significant delay on
Android. Therefore, we should have a solution that works in the current version
of the code as well.

+                   child_id,
+                   request_data.render_frame_id,
+                   request_data.url));
+  }
   BeginRequest(request_id, request_data, NULL, routing_id);
 }
 
 // Begins a resource request with the given params on behalf of the specified
 // child process.  Responses will be dispatched through the given receiver. The
 // process ID is used to lookup WebContentsImpl from routing_id's in the case of
 // a request from a renderer.  request_context is the cookie/cache context to be
 // used for this request.
 //
 // If sync_result is non-null, then a SyncLoad reply will be generated, else
@@ skipping 1148 matching lines @@
 
   // Add a flag to selectively bypass the data reduction proxy if the resource
   // type is not an image.
   if (request_data.resource_type != RESOURCE_TYPE_IMAGE)
     load_flags |= net::LOAD_BYPASS_DATA_REDUCTION_PROXY;
 
   return load_flags;
 }
 
 }  // namespace content