Add time-to-network histogram considering browser side navigation

content/browser/frame_host/navigator_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_
 
 #include "base/memory/ref_counted.h"
+#include "base/time/time.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
 #include "content/browser/frame_host/navigator.h"
 #include "content/common/content_export.h"

[clamy, 2014/09/19 14:56:03]

You need to include url/gurl.h since you now have a class GURL member down
there.

[carlosk, 2014/09/23 17:02:57]

Done.

 
 struct FrameMsg_Navigate_Params;
 
 namespace content {
 
 class NavigationControllerImpl;
 class NavigatorDelegate;
 struct LoadCommittedDetails;
 
 // This class is an implementation of Navigator, responsible for managing
@@ skipping 49 matching lines @@
       const Referrer& referrer,
       PageTransition page_transition,
       WindowOpenDisposition disposition,
       const GlobalRequestID& transferred_global_request_id,
       bool should_replace_current_entry,
       bool user_gesture) OVERRIDE;
   virtual void CommitNavigation(
       RenderFrameHostImpl* render_frame_host,
       const NavigationBeforeCommitInfo& info) OVERRIDE;
 
+  virtual void LogResourceRequestTime(base::TimeTicks timestamp, GURL url)
+      OVERRIDE;
+
  private:
   virtual ~NavigatorImpl() {}
 
   // Navigates to the given entry, which must be the pending entry.  Private
   // because all callers should use NavigateToPendingEntry.
   bool NavigateToEntry(
       RenderFrameHostImpl* render_frame_host,
       const NavigationEntryImpl& entry,
       NavigationController::ReloadType reload_type);
 
   bool ShouldAssignSiteForURL(const GURL& url);
 
   void CheckWebUIRendererDoesNotDisplayNormalURL(
     RenderFrameHostImpl* render_frame_host,
     const GURL& url);
 
   // The NavigationController that will keep track of session history for all
   // RenderFrameHost objects using this NavigatorImpl.
   // TODO(nasko): Move ownership of the NavigationController from
   // WebContentsImpl to this class.
   NavigationControllerImpl* controller_;
 
   // Used to notify the object embedding this Navigator about navigation
   // events. Can be NULL in tests.
   NavigatorDelegate* delegate_;
 
+  // The time the latest navigation request started for histogram building

[clamy, 2014/09/19 14:56:03]

nit: How about: The time the latest navigation request started, used in
Navigation.TimeToURLJobStart (or whatever we end up calling the histogram).

[carlosk, 2014/09/23 17:02:57]

Done but I mentioned the group name instead as there will be more than one
histogram based on this value.

+  // purposes.
+  base::TimeTicks navigation_start_time_;
+  // The URL of a started navigation to double check later if reported times
+  // match the currently active navigation.
+  GURL navigation_start_url_;
+
   DISALLOW_COPY_AND_ASSIGN(NavigatorImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_