Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 577943002: Add a commandline flag for disabling the SVG 1 DOM. (Closed)

Created:
6 years, 3 months ago by Erik Dahlström (inactive)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, asvitkine+watch_chromium.org, creis+watch_chromium.org, pdr., fs
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a commandline flag for disabling the SVG 1 DOM. Depends on https://codereview.chromium.org/474013004. BUG=415074 Committed: https://crrev.com/1a41fa7ed7b892bfdafbfde9beb12a265c722203 Cr-Commit-Position: refs/heads/master@{#300436}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : fix nit + rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Erik Dahlström (inactive)
6 years, 3 months ago (2014-09-17 11:22:36 UTC) #2
jam
lgtm with nit https://codereview.chromium.org/577943002/diff/20001/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/577943002/diff/20001/content/browser/renderer_host/render_process_host_impl.cc#newcode1219 content/browser/renderer_host/render_process_host_impl.cc:1219: switches::kDisableSVG1DOM, put this before the ifdef ...
6 years, 3 months ago (2014-09-19 18:44:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/577943002/40001
6 years, 2 months ago (2014-10-20 07:50:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18601) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/25917)
6 years, 2 months ago (2014-10-20 08:00:35 UTC) #7
Erik Dahlström (inactive)
On 2014/10/20 08:00:35, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-20 08:09:26 UTC) #11
Ilya Sherman
histograms.xml lgtm
6 years, 2 months ago (2014-10-21 01:29:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/577943002/40001
6 years, 2 months ago (2014-10-21 01:33:17 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18843) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/25917)
6 years, 2 months ago (2014-10-21 01:43:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/577943002/50006
6 years, 2 months ago (2014-10-21 07:34:36 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:50006)
6 years, 2 months ago (2014-10-21 08:29:58 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 08:30:44 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1a41fa7ed7b892bfdafbfde9beb12a265c722203
Cr-Commit-Position: refs/heads/master@{#300436}

Powered by Google App Engine
This is Rietveld 408576698