content/browser/devtools/render_view_devtools_agent_host.h - Issue 577923002: [DevTools] Implement DevToolsManager::Observer which notifies about target updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_view_devtools_agent_host.h

Issue 577923002: [DevTools] Implement DevToolsManager::Observer which notifies about target updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-enumerate-to-dtm-delegate

Patch Set: fixed test flakiness Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/embedded_worker_devtools_manager.cc ('k') | content/browser/devtools/render_view_devtools_agent_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/render_view_devtools_agent_host.h

diff --git a/content/browser/devtools/render_view_devtools_agent_host.h b/content/browser/devtools/render_view_devtools_agent_host.h

index 089933cd10bda103a4382046b9ce91b55c51b31c..0fcb680a166eea700762016aeec0484a2f9bc645 100644

--- a/content/browser/devtools/render_view_devtools_agent_host.h

+++ b/content/browser/devtools/render_view_devtools_agent_host.h

@@ -79,6 +79,9 @@ class CONTENT_EXPORT RenderViewDevToolsAgentHost

virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

virtual void DidAttachInterstitialPage() OVERRIDE;

virtual void DidDetachInterstitialPage() OVERRIDE;

+ virtual void TitleWasSet(NavigationEntry* entry, bool explicit_set) OVERRIDE;

+ virtual void NavigationEntryCommitted(

+ const LoadCommittedDetails& load_details) OVERRIDE;

// NotificationObserver overrides:

virtual void Observe(int type,