[DevTools] Implement DevToolsManager::Observer which notifies about target updates.

[DevTools] Implement DevToolsManager::Observer which notifies about target updates.

BUG=398049
Committed: https://crrev.com/24bfc91b5903da97ed5f9330b701b92356688108
Cr-Commit-Position: refs/heads/master@{#297154}

[dgozman, 2014-09-19 11:43:04]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2014-09-19 11:43:05]

Take a look please.

[dgozman, 2014-09-22 09:21:24]

dgozman@chromium.org changed reviewers:
+ vkuzkokov@chromium.org

[dgozman, 2014-09-22 09:21:25]

Vlad, please take a look.

[vkuzkokov, 2014-09-22 10:50:55]

On 2014/09/22 09:21:25, dgozman wrote:
> Vlad, please take a look.

lgtm

[pfeldman, 2014-09-22 16:16:50]

lgtm

https://codereview.chromium.org/577923002/diff/40001/content/browser/devtools...
File content/browser/devtools/devtools_manager.h (right):

https://codereview.chromium.org/577923002/diff/40001/content/browser/devtools...
content/browser/devtools/devtools_manager.h:29: class Observer {
This is something in between of listener and observer as per our style.

https://codereview.chromium.org/577923002/diff/40001/content/browser/devtools...
File content/browser/devtools/render_view_devtools_agent_host.h (right):

https://codereview.chromium.org/577923002/diff/40001/content/browser/devtools...
content/browser/devtools/render_view_devtools_agent_host.h:81: const
LoadCommittedDetails& load_details) OVERRIDE;
wrong indent

[dgozman, 2014-09-24 13:18:28]

https://codereview.chromium.org/577923002/diff/40001/content/browser/devtools...
File content/browser/devtools/devtools_manager.h (right):

https://codereview.chromium.org/577923002/diff/40001/content/browser/devtools...
content/browser/devtools/devtools_manager.h:29: class Observer {
On 2014/09/22 16:16:50, pfeldman wrote:
> This is something in between of listener and observer as per our style.

I've added all empty implementations, and left this as Observer.

https://codereview.chromium.org/577923002/diff/40001/content/browser/devtools...
File content/browser/devtools/render_view_devtools_agent_host.h (right):

https://codereview.chromium.org/577923002/diff/40001/content/browser/devtools...
content/browser/devtools/render_view_devtools_agent_host.h:81: const
LoadCommittedDetails& load_details) OVERRIDE;
On 2014/09/22 16:16:50, pfeldman wrote:
> wrong indent

Done.

[dgozman, 2014-09-24 13:21:20]

dgozman@chromium.org changed reviewers:
+ jam@chromium.org

[dgozman, 2014-09-24 13:21:20]

John, could you please take a look at web_contents_impl.cc?

This patch adds a hook on creation from WebContentsImpl to DevToolsManager, so
we can notify about new inspection targets. It does nothing if there are no
clients.

[jam, 2014-09-25 22:43:49]

lgtm

[dgozman, 2014-09-26 09:03:22]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-09-26 09:04:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/577923002/60001

[commit-bot: I haz the power, 2014-09-26 09:29:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-26 09:29:52]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dgozman, 2014-09-26 10:02:04]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-09-26 10:03:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/577923002/80001

[commit-bot: I haz the power, 2014-09-26 12:05:40]

Committed patchset #5 (id:80001) as b3c2df0392174fd163424e98b078e3df1419b8ba

[commit-bot: I haz the power, 2014-09-26 12:06:08]

Patchset 5 (id:??) landed as
https://crrev.com/509c17cf55a12b49b017245f6d0cff558f312637
Cr-Commit-Position: refs/heads/master@{#296921}

[dgozman, 2014-09-26 15:24:19]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/591313006/ by dgozman@chromium.org.

The reason for reverting is: Breaks asan bot.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....

[dgozman, 2014-09-26 16:20:38]

Patchset #6 (id:100001) has been deleted

[dgozman, 2014-09-26 16:20:57]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-09-26 16:21:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/577923002/120001

[commit-bot: I haz the power, 2014-09-26 17:28:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-26 17:28:20]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2014-09-29 10:09:59]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-09-29 10:10:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/577923002/140001

[commit-bot: I haz the power, 2014-09-29 11:04:58]

Committed patchset #7 (id:140001) as c2c9d3217f93213fd90639499eaa22e42b266ac5

[commit-bot: I haz the power, 2014-09-29 11:05:55]

Patchset 7 (id:??) landed as
https://crrev.com/24bfc91b5903da97ed5f9330b701b92356688108
Cr-Commit-Position: refs/heads/master@{#297154}