Fix flakiness related to routing policy override in RNDIS forwarder.

Fix flakiness related to routing policy override in RNDIS forwarder.

Routing policy override is needed at the point where ping test is executed in AndroidRndisConfigurator or the ping may fail.

It's also needed after DNS is changed in AndroidRndisForwarder constructor as executing setifdns may reset the policy table.

Thus we need to make multiple calls to OverrideRoutingPolicy() during RNDIS forwarder creation lifecycle.  But this is ok since the function is idempotent.

BUG=

Committed: https://crrev.com/366f7a7500ef5951b17bb8aeb087fcd90559e347
Cr-Commit-Position: refs/heads/master@{#295222}

[wuhu, 2014-09-17 00:37:54]

wuhu@google.com changed reviewers:
+ nednguyen@google.com, tonyg@chromium.org

[wuhu, 2014-09-17 00:37:55]

Routing policy override is needed at the point where ping test is executed in
AndroidRndisConfigurator or the ping may fail.

It's also needed after DNS is changed in AndroidRndisForwarder constructor as
executing setifdns may reset the policy table.

Thus we need to make multiple calls to OverrideRoutingPolicy() during RNDIS
forwarder creation lifecycle.  But this is ok since the function is idempotent.

[tonyg, 2014-09-17 01:14:19]

On 2014/09/17 00:37:55, wuhu wrote:
> Routing policy override is needed at the point where ping test is executed in
> AndroidRndisConfigurator or the ping may fail.
> 
> It's also needed after DNS is changed in AndroidRndisForwarder constructor as
> executing setifdns may reset the policy table.
> 
> Thus we need to make multiple calls to OverrideRoutingPolicy() during RNDIS
> forwarder creation lifecycle.  But this is ok since the function is
idempotent.

Please add the information in this comment to the patch description and then
this LGTM

[wuhu, 2014-09-17 01:33:37]

The CQ bit was checked by wuhu@google.com

[commit-bot: I haz the power, 2014-09-17 01:34:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/577853002/1

[nednguyen, 2014-09-17 01:36:43]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2014-09-17 01:43:03]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-09-17 01:44:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/577853002/1

[commit-bot: I haz the power, 2014-09-17 03:44:45]

Committed patchset #1 (id:1) as 99e1c6f294965bfbb70f359c4fa5f7f844437a13

[commit-bot: I haz the power, 2014-09-17 03:45:19]

Patchset 1 (id:??) landed as
https://crrev.com/366f7a7500ef5951b17bb8aeb087fcd90559e347
Cr-Commit-Position: refs/heads/master@{#295222}