Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 577843003: Revert of Add public API generation with cr.makePublic() and handle it in compiler pass (Closed)

Created:
6 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, tfarina, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, gcasto+watchlist_chromium.org, stevenjb+watch_chromium.org, mkwst+watchlist_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@H_options_errors_3
Project:
chromium
Visibility:
Public.

Description

Revert of Add public API generation with cr.makePublic() and handle it in compiler pass (patchset #10 id:180001 of https://codereview.chromium.org/557633002/) Reason for revert: Likely culprit for OOBE WebUI test breakage. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%282%29/builds/1974/steps/browser_tests/logs/stdio Original issue's description: > Add public API generation with cr.makePublic() and handle it in compiler pass > > R=dbeam@chromium.org,tbreisacher@chromium.org > BUG=393873 > TEST=third_party/closure_compiler/runner/how_to_test_compiler_pass.md > > Committed: https://crrev.com/730652530d108372ef14f62b89665197628f7880 > Cr-Commit-Position: refs/heads/master@{#295173} TBR=dbeam@chromium.org,tbreisacher@chromium.org,vitalyp@chromium.org NOTREECHECKS=true NOTRY=true BUG=393873 Committed: https://crrev.com/7ac26543e7a224a231e5ab3ed8a83ad5b94472a3 Cr-Commit-Position: refs/heads/master@{#295202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -363 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.js View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/automatic_settings_reset_banner.js View 2 chunks +7 lines, -26 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 6 chunks +13 lines, -20 lines 0 comments Download
M chrome/browser/resources/options/chromeos/change_picture_options.js View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/chromeos/keyboard_overlay.js View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 6 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/password_manager.js View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/settings_banner.js View 2 chunks +26 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/startup_overlay.js View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/supervised_user_create_confirm.js View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/supervised_user_import.js View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/supervised_user_list_data.js View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/closure_compiler/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/closure_compiler/runner/runner.jar View Binary file 0 comments Download
M third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java View 5 chunks +1 line, -110 lines 0 comments Download
M third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java View 1 chunk +0 lines, -162 lines 0 comments Download
M ui/webui/resources/js/cr.js View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of Add public API generation with cr.makePublic() and handle it in compiler pass
6 years, 3 months ago (2014-09-17 01:04:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577843003/1
6 years, 3 months ago (2014-09-17 01:04:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1cace7ac5bc17ee3491c75d74d483a7c892df79c
6 years, 3 months ago (2014-09-17 01:05:46 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 01:06:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ac26543e7a224a231e5ab3ed8a83ad5b94472a3
Cr-Commit-Position: refs/heads/master@{#295202}

Powered by Google App Engine
This is Rietveld 408576698