Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 577823002: Moves ProfilerMetricsProvider to //components/metrics. (Closed)

Created:
6 years, 3 months ago by gunsch
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org, lcwu1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Moves ProfilerMetricsProvider to //components/metrics. R=asvitkine@chromium.org,isherman@chromium.org, BUG=404791 Committed: https://crrev.com/840bc4163159ba58413ffa9658e888b1336851fe Cr-Commit-Position: refs/heads/master@{#295527}

Patch Set 1 #

Total comments: 2

Patch Set 2 : gyp fixes rebased #

Patch Set 3 : rebaase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -896 lines) Patch
M chrome/browser/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/metrics/profiler_metrics_provider.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/metrics/profiler_metrics_provider.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/browser/metrics/profiler_metrics_provider_unittest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D chrome/browser/metrics/tracking_synchronizer.h View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/metrics/tracking_synchronizer.cc View 1 chunk +0 lines, -297 lines 0 comments Download
D chrome/browser/metrics/tracking_synchronizer_observer.h View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/browser/ui/webui/profiler_ui.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/profiler_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 chunks +1 line, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M components/metrics.gypi View 1 1 chunk +20 lines, -0 lines 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +19 lines, -0 lines 0 comments Download
A + components/metrics/profiler/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/metrics/profiler/profiler_metrics_provider.h View 4 chunks +11 lines, -7 lines 0 comments Download
A + components/metrics/profiler/profiler_metrics_provider.cc View 5 chunks +10 lines, -7 lines 0 comments Download
A + components/metrics/profiler/profiler_metrics_provider_unittest.cc View 3 chunks +24 lines, -22 lines 0 comments Download
A + components/metrics/profiler/tracking_synchronizer.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/metrics/profiler/tracking_synchronizer.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/metrics/profiler/tracking_synchronizer_observer.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
gunsch
asvitkine/isherman: PTAL! +mseaborn for components/nacl/common (added DEPS moving code to components/metrics/profiler/DEPS, no functionality change). Include ...
6 years, 3 months ago (2014-09-17 00:04:01 UTC) #2
Lei Zhang
non-metrics chrome/ changes lgtm
6 years, 3 months ago (2014-09-17 00:33:37 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/577823002/diff/1/components/metrics.gypi File components/metrics.gypi (right): https://codereview.chromium.org/577823002/diff/1/components/metrics.gypi#newcode99 components/metrics.gypi:99: 'metrics/profiler/profiler_metrics_provider.cc', Seems like there's a mistake with this diff? ...
6 years, 3 months ago (2014-09-17 15:07:02 UTC) #4
gunsch
https://codereview.chromium.org/577823002/diff/1/components/metrics.gypi File components/metrics.gypi (right): https://codereview.chromium.org/577823002/diff/1/components/metrics.gypi#newcode99 components/metrics.gypi:99: 'metrics/profiler/profiler_metrics_provider.cc', On 2014/09/17 15:07:02, Alexei Svitkine wrote: > Seems ...
6 years, 3 months ago (2014-09-17 17:28:28 UTC) #5
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-09-17 17:34:27 UTC) #6
gunsch
+jochen for a content/ OWNER: TrackingSynchronizer and ProfilerMetricsProvider depend on content/public/browser and content/public/common. Moved to ...
6 years, 3 months ago (2014-09-17 18:42:50 UTC) #8
Mark Seaborn
On 2014/09/17 00:04:01, gunsch wrote: > +mseaborn for components/nacl/common (added DEPS moving code to > ...
6 years, 3 months ago (2014-09-17 20:30:23 UTC) #9
jochen (gone - plz use gerrit)
On 2014/09/17 at 18:42:50, gunsch wrote: > +jochen for a content/ OWNER: TrackingSynchronizer and ProfilerMetricsProvider ...
6 years, 3 months ago (2014-09-18 18:26:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/577823002/20001
6 years, 3 months ago (2014-09-18 18:30:25 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/57792) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/62587) android_aosp ...
6 years, 3 months ago (2014-09-18 18:35:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/577823002/40001
6 years, 3 months ago (2014-09-18 18:40:03 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e1637c990568588a5e8eff726bce37cc4013e49c
6 years, 3 months ago (2014-09-18 19:38:15 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 19:38:59 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/840bc4163159ba58413ffa9658e888b1336851fe
Cr-Commit-Position: refs/heads/master@{#295527}

Powered by Google App Engine
This is Rietveld 408576698