Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 577793004: libwebp: cherry-pick arm gcc-4.9 fix (Closed)

Created:
6 years, 3 months ago by jzern
Modified:
6 years, 3 months ago
Reviewers:
urvang (Google), skal
CC:
chromium-reviews, urvang (Google), skal, vikasa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

libwebp: cherry-pick arm gcc-4.9 fix dsp/lossless: workaround gcc-4.9 bug on arm force Sub3() to not be inlined, otherwise the code in Select() will be incorrect. https://android-review.googlesource.com/#/c/102511 Change-Id: I90ae58bf3e6cc92ca9897f69974733d562e29aaf BUG=414154 Committed: https://crrev.com/5d66c69dc9d7dd1446cb529686c2cc861e5eb2a7 Cr-Commit-Position: refs/heads/master@{#295506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M third_party/libwebp/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libwebp/dsp/lossless.c View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
jzern
On 2014/09/17 01:54:52, jzern wrote: > mailto:jzern@chromium.org changed reviewers: > + mailto:urvang@google.com ping
6 years, 3 months ago (2014-09-18 02:28:56 UTC) #2
skal
lgtm
6 years, 3 months ago (2014-09-18 05:23:34 UTC) #4
urvang (Google)
lgtm
6 years, 3 months ago (2014-09-18 17:42:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/577793004/1
6 years, 3 months ago (2014-09-18 17:44:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 872f8e219df8cfcad199b1589199cd6b5d815ff6
6 years, 3 months ago (2014-09-18 18:46:09 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:46:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d66c69dc9d7dd1446cb529686c2cc861e5eb2a7
Cr-Commit-Position: refs/heads/master@{#295506}

Powered by Google App Engine
This is Rietveld 408576698