Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 577793002: Replace missing call to RenderFrameHostImpl::Init(). (Closed)

Created:
6 years, 3 months ago by Charlie Reis
Modified:
6 years, 3 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, mkwst+moarreviews-content_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace missing call to RenderFrameHostImpl::Init(). This only affects renderer-created windows. It resumes blocked requests for the RenderFrameHost, which is currently a no-op (until we start routing network requests through RenderFrameHost rather than RenderViewHost). BUG=414947 TEST=RFH's requests unblocked after window.open. (No behavior change.) Committed: https://crrev.com/82dd6af930a59e47c31ef58dbd3644014dde3589 Cr-Commit-Position: refs/heads/master@{#295286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
I haven't found a good way to test this, since it currently has no observable ...
6 years, 3 months ago (2014-09-16 23:24:59 UTC) #2
nasko
lgtm
6 years, 3 months ago (2014-09-17 06:46:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577793002/1
6 years, 3 months ago (2014-09-17 15:59:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 33bfbd907857b21483cd4f629fc2b6fc9d6380ec
6 years, 3 months ago (2014-09-17 16:30:52 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 16:31:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82dd6af930a59e47c31ef58dbd3644014dde3589
Cr-Commit-Position: refs/heads/master@{#295286}

Powered by Google App Engine
This is Rietveld 408576698