Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 577763002: [NaCl SDK] Fix sys/time.h and utime.h headers (Closed)

Created:
6 years, 3 months ago by binji
Modified:
6 years, 3 months ago
Reviewers:
bradnelson, bradn, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Fix sys/time.h and utime.h headers include_next must be outside the include guard! When naclports builds a package, it copies the headers from $NACL_SDK_ROOT/include/$toolchain directly into the toolchain include directories (i.e. toolchain/linux_x86_newlib/x86_64-nacl/usr/include). This means that the same header is included twice in the header seach path, e.g.: $NACL_SDK_ROOT/include/newlib/foo.h $NACL_SDK_ROOT/toolchain/linux_x86_newlib/x86_64-nacl/usr/include/foo.h If include_next is inside the include guard, then the full include chain for that header name will not be followed (it will stop when it hits the same include guard). BUG=none R=bradnelson@google.com, sbc@chromium.org, bradnelson@chromium.org Committed: https://crrev.com/2b6e7b2f800fb5ec9755492d208175c95d8531c7 Cr-Commit-Position: refs/heads/master@{#295164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M native_client_sdk/src/libraries/nacl_io/include/sys/time.h View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/include/utime.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
6 years, 3 months ago (2014-09-16 21:41:30 UTC) #1
bradn
lgtm
6 years, 3 months ago (2014-09-16 21:54:01 UTC) #3
Sam Clegg
lgtm. Sorry about not flagging this in the initial review.
6 years, 3 months ago (2014-09-16 21:57:06 UTC) #4
binji
Committed patchset #1 (id:1) manually as 2b6e7b2 (presubmit successful).
6 years, 3 months ago (2014-09-16 22:44:23 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 22:44:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b6e7b2f800fb5ec9755492d208175c95d8531c7
Cr-Commit-Position: refs/heads/master@{#295164}

Powered by Google App Engine
This is Rietveld 408576698