cc: Don't clip tile priority visible rect to content bounds.

cc: Don't clip tile priority visible rect to content bounds.

The tile priority visible rect is sometimes expected to be not
intersecting the layer bounds. That's expected, since the layer
might be offscreen. In those cases we should still be correctly
prioritizing and creating tiles. This fix addresses that.

BUG=414521
R=danakj

Committed: https://crrev.com/9d9da8d4328a53762f65b973ddf02f7a5707e6d8
Cr-Commit-Position: refs/heads/master@{#295630}

[vmpstr, 2014-09-16 21:41:31]

PTAL

[danakj, 2014-09-18 16:48:22]

https://codereview.chromium.org/577753002/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/577753002/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.cc:486: gfx::Rect visible_layer_rect =
GetViewportForTilePriorityInContentSpace();
can you rename this? it's not the visible layer rect. it's the
viewport_rect_in_layer_space or something

[vmpstr, 2014-09-18 22:54:08]

PTAL

https://codereview.chromium.org/577753002/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/577753002/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.cc:486: gfx::Rect visible_layer_rect =
GetViewportForTilePriorityInContentSpace();
On 2014/09/18 16:48:22, danakj wrote:
> can you rename this? it's not the visible layer rect. it's the
> viewport_rect_in_layer_space or something

Done.

[danakj, 2014-09-18 23:18:38]

LGTM

[danakj, 2014-09-18 23:18:41]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-09-18 23:18:50]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-09-18 23:19:36]

https://codereview.chromium.org/577753002/diff/20001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl_unittest.cc (left):

https://codereview.chromium.org/577753002/diff/20001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl_unittest.cc:408: // Interset
viewport_rect_for_tile_priority_in_view_space with the layer
It would be really easy to add back that intersect and just say "oh this test
must be wrong". Can you add a comment explaining here why the rect should be
outside the layer bounds?

[vmpstr, 2014-09-18 23:58:46]

https://codereview.chromium.org/577753002/diff/20001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl_unittest.cc (left):

https://codereview.chromium.org/577753002/diff/20001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl_unittest.cc:408: // Interset
viewport_rect_for_tile_priority_in_view_space with the layer
On 2014/09/18 23:19:36, danakj wrote:
> It would be really easy to add back that intersect and just say "oh this test
> must be wrong". Can you add a comment explaining here why the rect should be
> outside the layer bounds?

Done.

[vmpstr, 2014-09-18 23:58:50]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-09-18 23:59:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/577753002/40001

[commit-bot: I haz the power, 2014-09-19 01:06:33]

Committed patchset #3 (id:40001) as 38c0317dd7b6fa66fbeff6e3c57f04f0d84dc67c

[commit-bot: I haz the power, 2014-09-19 01:07:08]

Patchset 3 (id:??) landed as
https://crrev.com/9d9da8d4328a53762f65b973ddf02f7a5707e6d8
Cr-Commit-Position: refs/heads/master@{#295630}