Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: chrome/browser/lifetime/application_lifetime_win.cc

Issue 57773004: Fixing issue with early unset of version variable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/lifetime/application_lifetime_win.cc
diff --git a/chrome/browser/lifetime/application_lifetime_win.cc b/chrome/browser/lifetime/application_lifetime_win.cc
index c5ea8a2c87c49761d953131fe9c9b5ac92595a0b..9c5cbdeed41068bcb0159611c6925ec85d086c48 100644
--- a/chrome/browser/lifetime/application_lifetime_win.cc
+++ b/chrome/browser/lifetime/application_lifetime_win.cc
@@ -71,9 +71,7 @@ void ActivateDesktopHelper() {
std::string version_str;
// Get the version variable and remove it from the environment.
- if (env->GetVar(chrome::kChromeVersionEnvVar, &version_str))
- env->UnSetVar(chrome::kChromeVersionEnvVar);
- else
+ if (!env->GetVar(chrome::kChromeVersionEnvVar, &version_str))
version_str.clear();
base::FilePath exe_path;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698