Introduce EasyUnlockService class for signin profile

Introduce EasyUnlockService class for signin profile

This makes EasyUnlockService pure virtual base class and introduces
separate implementations for regular and signin profiles. Common code
for both service types is kept in EasyUnlockService class.

EasyunlockService for signin profile is left empty.

BUG=401634
Committed: https://crrev.com/390ac978eb1a70aa848faa4fc659f8851ecd5b44
Cr-Commit-Position: refs/heads/master@{#295188}

[tbarzic, 2014-09-16 20:54:03]

tbarzic@chromium.org changed reviewers:
+ xiyuan@chromium.org

[tbarzic, 2014-09-16 20:54:04]

Can you take a look. There should be no real functional changes.

not chrome/browser/signin/easy_unlock_service_regular.cc diff to patchset 4 is
diff to old chrome/browser/signin/easy_unlock_service.cc

[xiyuan, 2014-09-16 22:00:00]

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
File chrome/browser/signin/easy_unlock_service.h (right):

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.h:124: class BluetoothDetector;
nit: class declaration before function declaration. i.e. this should precede
Initialize.

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.h:130: Profile* profile_;
Can we keep this in private and expose to sub class via an accessor?

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.h:133:
scoped_ptr<EasyUnlockScreenlockStateHandler> screenlock_state_handler_;
sub class seems not accessing it. Let's keep it private.

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.h:135: TurnOffFlowStatus
turn_off_flow_status_;
Think we want to get rid of this here and change turn_off_flow_status() to be
virtual.

Or alternatively, keeping this one and get rid of |turn_off_flow_status_| in
EasyUnlockServiceRegular. If we do this, prefer to move it to private and
provide accessors.

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
File chrome/browser/signin/easy_unlock_service_factory.cc (right):

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service_factory.cc:12: #include
"chrome/browser/signin/easy_unlock_service_signin_chromeos.h"
Move this into #if defined(OS_CHROMEOS) around line 18 since it is chromeos
only.

[tbarzic, 2014-09-16 22:30:58]

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
File chrome/browser/signin/easy_unlock_service.h (right):

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.h:124: class BluetoothDetector;
On 2014/09/16 21:59:59, xiyuan wrote:
> nit: class declaration before function declaration. i.e. this should precede
> Initialize.

Done.

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.h:130: Profile* profile_;
On 2014/09/16 21:59:59, xiyuan wrote:
> Can we keep this in private and expose to sub class via an accessor?

Done.

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.h:133:
scoped_ptr<EasyUnlockScreenlockStateHandler> screenlock_state_handler_;
On 2014/09/16 21:59:59, xiyuan wrote:
> sub class seems not accessing it. Let's keep it private.

Done.

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.h:135: TurnOffFlowStatus
turn_off_flow_status_;
On 2014/09/16 21:59:59, xiyuan wrote:
> Think we want to get rid of this here and change turn_off_flow_status() to be
> virtual.
> 
> Or alternatively, keeping this one and get rid of |turn_off_flow_status_| in
> EasyUnlockServiceRegular. If we do this, prefer to move it to private and
> provide accessors.

Done.

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
File chrome/browser/signin/easy_unlock_service_factory.cc (right):

https://codereview.chromium.org/577683002/diff/80001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service_factory.cc:12: #include
"chrome/browser/signin/easy_unlock_service_signin_chromeos.h"
On 2014/09/16 21:59:59, xiyuan wrote:
> Move this into #if defined(OS_CHROMEOS) around line 18 since it is chromeos
> only.

d'oh forgot to move it when I made the file cros-only

[xiyuan, 2014-09-16 22:39:28]

lgtm

[tbarzic, 2014-09-16 22:43:41]

The CQ bit was checked by tbarzic@chromium.org

[commit-bot: I haz the power, 2014-09-16 22:44:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/577683002/100001

[commit-bot: I haz the power, 2014-09-17 00:26:41]

Committed patchset #6 (id:100001) as a7cda9f6296e287e1c3a89cc5b848ac87e1aa63b

[commit-bot: I haz the power, 2014-09-17 00:27:05]

Patchset 6 (id:??) landed as
https://crrev.com/390ac978eb1a70aa848faa4fc659f8851ecd5b44
Cr-Commit-Position: refs/heads/master@{#295188}