Issue 577673004: Add support for 'start_url' in Manifest.

Issue 577673004: Add support for 'start_url' in Manifest. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 3 months ago

Reviewers:
palmer, Avi (use Gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-content_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@manifest_manager_content

Project:
chromium

Visibility:
Public.

Add support for 'start_url' in Manifest. BUG=366145 Committed: https://crrev.com/c267d1ed82d7911e06f63775ea26a07b0d718c45 Cr-Commit-Position: refs/heads/master@{#295147}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -21 lines)			Patch
M	content/browser/manifest/manifest_manager_host.cc	View	3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/common/manifest_manager_messages.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/manifest.h	View	3	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/manifest/manifest_manager.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	content/renderer/manifest/manifest_manager.cc	View	3	2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/renderer/manifest/manifest_parser.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	content/renderer/manifest/manifest_parser.cc	View	1 3	3 chunks	+31 lines, -2 lines	0 comments	Download
M	content/renderer/manifest/manifest_parser_unittest.cc	View	3	1 chunk	+94 lines, -15 lines	0 comments	Download

Total messages: 11 (3 generated)

mlamouri (slow - plz ping)

palmer@, can you have a look at the IPC changes. avi@, can you have a ...

6 years, 3 months ago (2014-09-16 18:03:21 UTC) #2

mlamouri (slow - plz ping)

On 2014/09/16 18:03:21, Mounir Lamouri wrote: > palmer@, can you have a look at the ...

6 years, 3 months ago (2014-09-16 18:03:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577673004/20001

6 years, 3 months ago (2014-09-16 19:42:49 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577673004/60001

6 years, 3 months ago (2014-09-16 19:57:30 UTC) #9

commit-bot: I haz the power

Committed patchset #4 (id:60001) as 185a7b12c276451cde239eca2ad82c6000706a57

6 years, 3 months ago (2014-09-16 21:34:51 UTC) #10

commit-bot: I haz the power

6 years, 3 months ago (2014-09-16 21:35:24 UTC) #11

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/c267d1ed82d7911e06f63775ea26a07b0d718c45
Cr-Commit-Position: refs/heads/master@{#295147}