Issue 577673003: Turn disable or delete optimizations that don't have any effect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 577673003: Turn disable or delete optimizations that don't have any effect. (Closed)

Created:
6 years, 3 months ago by mtklein_C

Modified:
6 years, 3 months ago

Reviewers:
mtklein, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Turn disable or delete optimizations that don't have any effect. Recording gets a ~5% speedup. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1e78fc4ed2a1ef9f049311696ebd0a26e1c3782d

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -73 lines)			Patch
M	src/core/SkRecordOpts.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/core/SkRecordOpts.cpp	View	2 chunks	+6 lines, -46 lines	0 comments	Download
M	tests/RecordOptsTest.cpp	View	1 chunk	+0 lines, -24 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577673003/1

6 years, 3 months ago (2014-09-16 17:48:20 UTC) #4

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

6 years, 3 months ago (2014-09-16 17:48:21 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-16 18:11:23 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 1e78fc4ed2a1ef9f049311696ebd0a26e1c3782d