Issue 577643003: Add PRESUBMIT check for deprecated IPC_ENUM_TRAITS().

Issue 577643003: Add PRESUBMIT check for deprecated IPC_ENUM_TRAITS(). (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 3 months ago

Reviewers:
palmer, jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@web_app_information

Project:
chromium

Visibility:
Public.

Add PRESUBMIT check for deprecated IPC_ENUM_TRAITS(). BUG=414725 Committed: https://crrev.com/a8227262a9b8fddfe02fa5e8003ecf6a763ffa2b Cr-Commit-Position: refs/heads/master@{#295112}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	PRESUBMIT.py	View	1	3 chunks	+29 lines, -0 lines	0 comments	Download

Total messages: 9 (2 generated)

mlamouri (slow - plz ping)

I was told in https://codereview.chromium.org/568823003/ that IPC_ENUM_TRAITS() was deprecated. I've added a PRESUBMIT warning so ...

6 years, 3 months ago (2014-09-16 15:10:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577643003/20001

6 years, 3 months ago (2014-09-16 18:00:29 UTC) #7

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 55c37dd1deefa803c2ea452c4fa231a517a2c5ae

6 years, 3 months ago (2014-09-16 18:47:11 UTC) #8

commit-bot: I haz the power

6 years, 3 months ago (2014-09-16 18:48:27 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/a8227262a9b8fddfe02fa5e8003ecf6a763ffa2b
Cr-Commit-Position: refs/heads/master@{#295112}