Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 577583002: Drop RenderSVGResource::{fill,stroke}PaintingResource shims (Closed)

Created:
6 years, 3 months ago by fs
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Drop RenderSVGResource::{fill,stroke}PaintingResource shims Makes for slightly less branchy code in some places, otherwise very little difference. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -31 lines) Patch
M Source/core/rendering/svg/RenderSVGResource.h View 1 chunk +1 line, -11 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 chunk +8 lines, -14 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
As suggested by fmalita in https://codereview.chromium.org/563973003/
6 years, 3 months ago (2014-09-16 13:53:42 UTC) #2
Stephen Chennney
lgtm
6 years, 3 months ago (2014-09-16 15:28:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577583002/1
6 years, 3 months ago (2014-09-16 15:29:04 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 15:34:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182058

Powered by Google App Engine
This is Rietveld 408576698