Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 577563002: Re-reland "Use unsigned type bitsets to limit undefined behaviour" (Closed)

Created:
6 years, 3 months ago by rossberg
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Re-reland "Use unsigned type bitsets to limit undefined behaviour" Change: make bitset uint32_t, to avoid weird sign extension bugs on Win64. BUG= R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23978

Patch Set 1 #

Patch Set 2 : Remove debug #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -161 lines) Patch
M src/types.h View 1 12 chunks +78 lines, -78 lines 0 comments Download
M src/types.cc View 20 chunks +59 lines, -50 lines 0 comments Download
M src/types-inl.h View 5 chunks +14 lines, -11 lines 0 comments Download
M test/cctest/test-types.cc View 1 11 chunks +25 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rossberg
PTAL
6 years, 3 months ago (2014-09-16 10:52:08 UTC) #2
Sven Panne
lgtm
6 years, 3 months ago (2014-09-16 12:52:15 UTC) #3
rossberg
6 years, 3 months ago (2014-09-16 12:58:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as 23978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698