Issue 577553002: AX: Make picker indicator elements focusable if accessibility is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 577553002: AX: Make picker indicator elements focusable if accessibility is enabled. (Closed)

Created:
6 years, 3 months ago by tkent

Modified:
6 years, 3 months ago

Reviewers:
keishi

CC:
blink-reviews, jamesr, blink-reviews-css, blink-reviews-html_chromium.org, ed+blinkwatch_opera.com, abarth-chromium, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

AX: Make picker indicator elements focusable if accessibility is enabled. We should provide a way to open calendar picker or datalist picker even if a user doesn't know key bindings to open them. This CL is not testable. We have no way to disable accessibility in layout tests, and LayoutTestHelper::isRunningLayoutTest() returns true in C++ unit tests too. BUG=123896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182041

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -1 line)			Patch
M	Source/core/css/html.css	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/html/shadow/PickerIndicatorElement.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/html/shadow/PickerIndicatorElement.cpp	View	3 chunks	+31 lines, -0 lines	0 comments	Download
M	public/platform/WebLocalizedString.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577553002/1

6 years, 3 months ago (2014-09-16 08:38:03 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-16 08:43:48 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182041

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages