Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1603)

Issue 577483002: Close all active PeerConnections upon OS suspend (relanding r290125 and r291213) (Closed)

Created:
6 years, 3 months ago by vrk (LEFT CHROMIUM)
Modified:
6 years, 3 months ago
Reviewers:
jiayl, juberti2, dcheng, nasko
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Close all active PeerConnections upon OS suspend (relanding r290125 and r291213) Relanding these CLs, this time making sure to remove self from PowerMonitor's observer list on the same thread as was added. BUG=403618, 404767 Committed: https://crrev.com/eccaaa926e9448d1d6c5b62848954222ed3410af Cr-Commit-Position: refs/heads/master@{#295297}

Patch Set 1 #

Patch Set 2 : fix crashing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -4 lines) Patch
M content/browser/renderer_host/media/peer_connection_tracker_host.h View 1 4 chunks +12 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/peer_connection_tracker_host.cc View 1 3 chunks +38 lines, -1 line 0 comments Download
M content/common/media/peer_connection_tracker_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/peer_connection_tracker.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/peer_connection_tracker.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vrk (LEFT CHROMIUM)
Trying to reland for the third time now. Please take a look at the diff ...
6 years, 3 months ago (2014-09-15 21:43:44 UTC) #2
jiayl
lgtm
6 years, 3 months ago (2014-09-15 22:42:15 UTC) #3
dcheng
IPC changes lgtm
6 years, 3 months ago (2014-09-17 17:09:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577483002/20001
6 years, 3 months ago (2014-09-17 17:10:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 07488504ca5d15050afc26f6e60dfaf726cfd2fe
6 years, 3 months ago (2014-09-17 18:06:22 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 18:07:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eccaaa926e9448d1d6c5b62848954222ed3410af
Cr-Commit-Position: refs/heads/master@{#295297}

Powered by Google App Engine
This is Rietveld 408576698