Simplify VideoReader and VideoWriter

remoting/protocol/video_reader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/video_reader.h"
 
-#include "remoting/protocol/session_config.h"
-#include "remoting/protocol/protobuf_video_reader.h"
+#include "base/bind.h"
+#include "net/socket/stream_socket.h"
+#include "remoting/base/constants.h"
+#include "remoting/proto/video.pb.h"
+#include "remoting/protocol/stream_channel_factory.h"
+#include "remoting/protocol/video_stub.h"
 
 namespace remoting {
 namespace protocol {
 
-VideoReader::~VideoReader() { }
+VideoReader::VideoReader()
+    : ChannelDispatcherBase(kVideoChannelName),

[Wez, 2014/09/16 23:10:06]

nit: Should the channel name be a parameter to the VideoReader?

If not then isn't VideoReader a too generic name - perhaps VideoChannel or
VideoChannelPump might be better?

[Sergey Ulanov, 2014/09/17 21:52:06]

I don't think it needs to be - it's consistent with other channel dispatcher
classes.
Renamed them to (Client|Host)VideoDispatcher for consistency with other
dispatchers

[Wez, 2014/09/18 00:23:54]

Acknowledged.

+      video_stub_(NULL) {
+}
 
-// static
-scoped_ptr<VideoReader> VideoReader::Create(const SessionConfig& config) {
-  const ChannelConfig& video_config = config.video_config();
-  if (video_config.transport == ChannelConfig::TRANSPORT_STREAM) {
-    if (video_config.codec == ChannelConfig::CODEC_VP8) {
-      return scoped_ptr<VideoReader>(
-          new ProtobufVideoReader(VideoPacketFormat::ENCODING_VP8));
-    } else if (video_config.codec == ChannelConfig::CODEC_VP9) {
-      return scoped_ptr<VideoReader>(
-          new ProtobufVideoReader(VideoPacketFormat::ENCODING_VP9));
-    } else if (video_config.codec == ChannelConfig::CODEC_ZIP) {
-      return scoped_ptr<VideoReader>(
-          new ProtobufVideoReader(VideoPacketFormat::ENCODING_ZLIB));
-    } else if (video_config.codec == ChannelConfig::CODEC_VERBATIM) {
-      return scoped_ptr<VideoReader>(
-          new ProtobufVideoReader(VideoPacketFormat::ENCODING_VERBATIM));
-    }
-  }
-  NOTREACHED();
-  return scoped_ptr<VideoReader>();
+VideoReader::~VideoReader() {
+}
+
+void VideoReader::OnInitialized() {
+  reader_.Init(channel(), base::Bind(&VideoReader::OnNewData,
+                                      base::Unretained(this)));
+}
+
+void VideoReader::OnNewData(scoped_ptr<VideoPacket> packet,
+                                    const base::Closure& done_task) {
+  video_stub_->ProcessVideoPacket(packet.Pass(), done_task);
 }
 
 }  // namespace protocol
 }  // namespace remoting