Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: extensions/renderer/guest_view/guest_view_container.cc

Issue 577453002: Rename ChromeBrowserPluginDelegate to GuestViewContainer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/guest_view_container.cc
diff --git a/chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc b/extensions/renderer/guest_view/guest_view_container.cc
similarity index 68%
rename from chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc
rename to extensions/renderer/guest_view/guest_view_container.cc
index fe5fd0c06fa98b68564885e46f628411e416372f..be8d6d56a99dc9991c18cc51600cd9f2ea950796 100644
--- a/chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc
+++ b/extensions/renderer/guest_view/guest_view_container.cc
@@ -2,44 +2,42 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h"
+#include "extensions/renderer/guest_view/guest_view_container.h"
#include "content/public/renderer/browser_plugin_delegate.h"
#include "content/public/renderer/render_frame.h"
#include "extensions/common/extension_messages.h"
+#include "extensions/common/guest_view/guest_view_constants.h"
-ChromeBrowserPluginDelegate::ChromeBrowserPluginDelegate(
+GuestViewContainer::GuestViewContainer(
content::RenderFrame* render_frame,
const std::string& mime_type)
: content::BrowserPluginDelegate(render_frame, mime_type),
content::RenderFrameObserver(render_frame),
mime_type_(mime_type),
- // TODO(lazyboy): Use browser_plugin::kInstanceIDNone.
- element_instance_id_(0) {
+ element_instance_id_(guestview::kInstanceIDNone) {
}
-ChromeBrowserPluginDelegate::~ChromeBrowserPluginDelegate() {
+GuestViewContainer::~GuestViewContainer() {
}
-void ChromeBrowserPluginDelegate::SetElementInstanceID(
+void GuestViewContainer::SetElementInstanceID(
int element_instance_id) {
element_instance_id_ = element_instance_id;
}
-void ChromeBrowserPluginDelegate::DidFinishLoading() {
+void GuestViewContainer::DidFinishLoading() {
DCHECK_NE(element_instance_id_, 0);
lazyboy 2014/09/15 20:23:42 s/0/kInstanceIDNone
Fady Samuel 2014/09/15 21:22:48 Done.
render_frame()->Send(new ExtensionHostMsg_CreateMimeHandlerViewGuest(
lazyboy 2014/09/15 20:23:42 Wouldn't this send an incorrect msg for view types
Fady Samuel 2014/09/15 21:22:48 Done.
routing_id(), html_string_, mime_type_, element_instance_id_));
}
-void ChromeBrowserPluginDelegate::DidReceiveData(const char* data,
- int data_length) {
+void GuestViewContainer::DidReceiveData(const char* data, int data_length) {
std::string value(data, data_length);
html_string_ += value;
}
-bool ChromeBrowserPluginDelegate::OnMessageReceived(
- const IPC::Message& message) {
+bool GuestViewContainer::OnMessageReceived(const IPC::Message& message) {
if (message.type() != ExtensionMsg_CreateMimeHandlerViewGuestACK::ID)
return false;
@@ -52,7 +50,7 @@ bool ChromeBrowserPluginDelegate::OnMessageReceived(
return false;
bool handled = true;
- IPC_BEGIN_MESSAGE_MAP(ChromeBrowserPluginDelegate, message)
+ IPC_BEGIN_MESSAGE_MAP(GuestViewContainer, message)
IPC_MESSAGE_HANDLER(ExtensionMsg_CreateMimeHandlerViewGuestACK,
OnCreateMimeHandlerViewGuestACK)
IPC_MESSAGE_UNHANDLED(handled = false)
@@ -60,7 +58,7 @@ bool ChromeBrowserPluginDelegate::OnMessageReceived(
return handled;
}
-void ChromeBrowserPluginDelegate::OnCreateMimeHandlerViewGuestACK(
+void GuestViewContainer::OnCreateMimeHandlerViewGuestACK(
int element_instance_id) {
DCHECK_NE(element_instance_id_, 0);
lazyboy 2014/09/15 20:23:42 ditto
Fady Samuel 2014/09/15 21:22:48 Done.
DCHECK_EQ(element_instance_id_, element_instance_id);
« no previous file with comments | « extensions/renderer/guest_view/guest_view_container.h ('k') | extensions/shell/renderer/shell_content_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698