Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 577453002: Rename ChromeBrowserPluginDelegate to GuestViewContainer (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, mkwst+moarreviews-content_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename ChromeBrowserPluginDelegate to GuestViewContainer This CL renames ChromeBrowserPluginDelegate to GuestViewContainer and moves it to extensions This CL moves guest_view_constants to extensions/common/* This CL also attaches a GuestViewContainer to all GuestViews. BUG=330264, 352290 Committed: https://crrev.com/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd Cr-Commit-Position: refs/heads/master@{#295034}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed comments #

Total comments: 2

Patch Set 3 : Addressed nit #

Patch Set 4 : Moved to extensions namespace #

Total comments: 2

Patch Set 5 : Addressed creis' comment #

Patch Set 6 : Rebased #

Patch Set 7 : Fix GN build #

Patch Set 8 : Second attempt at GN Build fix #

Total comments: 1

Patch Set 9 : Moved GuestViewContainer to ENABLE_EXTENSIONS guard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -206 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
D extensions/browser/guest_view/guest_view_constants.h View 1 chunk +0 lines, -29 lines 0 comments Download
D extensions/browser/guest_view/guest_view_constants.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M extensions/browser/guest_view/guest_view_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/javascript_dialog_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_permission_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/BUILD.gn View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/common/guest_view/guest_view_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/guest_view/guest_view_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 5 3 chunks +4 lines, -2 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/renderer/guest_view/guest_view_container.h View 1 2 3 2 chunks +14 lines, -10 lines 0 comments Download
A + extensions/renderer/guest_view/guest_view_container.cc View 1 2 3 3 chunks +23 lines, -17 lines 0 comments Download
M extensions/shell/renderer/shell_content_renderer_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/shell/renderer/shell_content_renderer_client.cc View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (11 generated)
Fady Samuel
6 years, 3 months ago (2014-09-15 20:05:53 UTC) #2
lazyboy
https://codereview.chromium.org/577453002/diff/1/extensions/renderer/guest_view/guest_view_container.cc File extensions/renderer/guest_view/guest_view_container.cc (right): https://codereview.chromium.org/577453002/diff/1/extensions/renderer/guest_view/guest_view_container.cc#newcode30 extensions/renderer/guest_view/guest_view_container.cc:30: DCHECK_NE(element_instance_id_, 0); s/0/kInstanceIDNone https://codereview.chromium.org/577453002/diff/1/extensions/renderer/guest_view/guest_view_container.cc#newcode31 extensions/renderer/guest_view/guest_view_container.cc:31: render_frame()->Send(new ExtensionHostMsg_CreateMimeHandlerViewGuest( Wouldn't this ...
6 years, 3 months ago (2014-09-15 20:23:42 UTC) #3
Fady Samuel
PTAL. https://codereview.chromium.org/577453002/diff/1/extensions/renderer/guest_view/guest_view_container.cc File extensions/renderer/guest_view/guest_view_container.cc (right): https://codereview.chromium.org/577453002/diff/1/extensions/renderer/guest_view/guest_view_container.cc#newcode30 extensions/renderer/guest_view/guest_view_container.cc:30: DCHECK_NE(element_instance_id_, 0); On 2014/09/15 20:23:42, lazyboy wrote: > ...
6 years, 3 months ago (2014-09-15 21:22:48 UTC) #4
lazyboy
LGTM with one more comment. https://codereview.chromium.org/577453002/diff/20001/extensions/renderer/guest_view/guest_view_container.cc File extensions/renderer/guest_view/guest_view_container.cc (right): https://codereview.chromium.org/577453002/diff/20001/extensions/renderer/guest_view/guest_view_container.cc#newcode66 extensions/renderer/guest_view/guest_view_container.cc:66: DCHECK_NE(element_instance_id_, guestview::kInstanceIDNone); Also DCHECK(!mime_type_.empty());
6 years, 3 months ago (2014-09-15 21:33:47 UTC) #5
Fady Samuel
+rockot@ for extensions review! Thanks https://codereview.chromium.org/577453002/diff/20001/extensions/renderer/guest_view/guest_view_container.cc File extensions/renderer/guest_view/guest_view_container.cc (right): https://codereview.chromium.org/577453002/diff/20001/extensions/renderer/guest_view/guest_view_container.cc#newcode66 extensions/renderer/guest_view/guest_view_container.cc:66: DCHECK_NE(element_instance_id_, guestview::kInstanceIDNone); On 2014/09/15 ...
6 years, 3 months ago (2014-09-15 21:54:37 UTC) #7
Fady Samuel
+creis@ for render_frame_impl change. +sky@ for chrome changes. Thanks!
6 years, 3 months ago (2014-09-15 21:55:42 UTC) #9
sky
LGTM
6 years, 3 months ago (2014-09-15 23:00:20 UTC) #10
Charlie Reis
render_frame_impl.cc LGTM with nit. https://codereview.chromium.org/577453002/diff/60001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/577453002/diff/60001/content/renderer/render_frame_impl.cc#newcode1557 content/renderer/render_frame_impl.cc:1557: this, base::UTF16ToUTF8(params.mimeType))); Can you just ...
6 years, 3 months ago (2014-09-15 23:04:12 UTC) #11
Fady Samuel
Ken, could you please take a look at extensions? https://codereview.chromium.org/577453002/diff/60001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/577453002/diff/60001/content/renderer/render_frame_impl.cc#newcode1557 content/renderer/render_frame_impl.cc:1557: ...
6 years, 3 months ago (2014-09-16 00:33:00 UTC) #12
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-16 01:47:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577453002/80001
6 years, 3 months ago (2014-09-16 02:57:27 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/56348) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/15325) ios_rel_device ...
6 years, 3 months ago (2014-09-16 03:01:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577453002/100001
6 years, 3 months ago (2014-09-16 03:54:00 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/15833)
6 years, 3 months ago (2014-09-16 04:13:33 UTC) #21
Ken Rockot(use gerrit already)
My bad, I missed that; you'll need to update //extensions/common/BUILD.gn as well. I'll fix this ...
6 years, 3 months ago (2014-09-16 04:18:18 UTC) #22
Ken Rockot(use gerrit already)
On 2014/09/16 04:18:18, Ken Rockot wrote: > My bad, I missed that; you'll need to ...
6 years, 3 months ago (2014-09-16 04:19:31 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577453002/120001
6 years, 3 months ago (2014-09-16 04:20:41 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577453002/140001
6 years, 3 months ago (2014-09-16 04:25:29 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/9094)
6 years, 3 months ago (2014-09-16 04:54:24 UTC) #29
Ken Rockot(use gerrit already)
https://codereview.chromium.org/577453002/diff/140001/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): https://codereview.chromium.org/577453002/diff/140001/chrome/renderer/chrome_content_renderer_client.cc#newcode1576 chrome/renderer/chrome_content_renderer_client.cc:1576: return new extensions::GuestViewContainer(render_frame, mime_type); Need to test ENABLE_EXTENSIONS
6 years, 3 months ago (2014-09-16 05:01:52 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577453002/160001
6 years, 3 months ago (2014-09-16 08:20:05 UTC) #32
commit-bot: I haz the power
Committed patchset #9 (id:160001) as f0390cc9d0c8f488f06421b41923b9a46a7d003d
6 years, 3 months ago (2014-09-16 09:19:24 UTC) #33
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 09:20:44 UTC) #34
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd
Cr-Commit-Position: refs/heads/master@{#295034}

Powered by Google App Engine
This is Rietveld 408576698