Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 577443004: Revert of Minor cleanup in EasyUnlockClient (Closed)

Created:
6 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Minor cleanup in EasyUnlockClient (patchset #2 id:20001 of https://codereview.chromium.org/569813002/) Reason for revert: Looks like some ChromeOS code was missed here; it's unclear why bots didn't catch this. Original issue's description: > Minor cleanup in EasyUnlockClient > > * arg names in GenerateEcP256KeyPairCallback typedef were reversed > * Make CreateSecureMEssage and UnwrapSecureMessage take structs (instead > of having long list of arguments) > > BUG=None > TEST=existing unittests > > Committed: https://crrev.com/35e3a9c7061205db58f57182f5ba5eb87be0f355 > Cr-Commit-Position: refs/heads/master@{#294954} TBR=stevenjb@chromium.org,isherman@chromium.org,tbarzic@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/b90decf7bb94f829c52601e284566e881f3774bb Cr-Commit-Position: refs/heads/master@{#294968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -222 lines) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 3 chunks +20 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc View 6 chunks +39 lines, -50 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate.h View 2 chunks +18 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate_chromeos.cc View 1 chunk +32 lines, -35 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate_stub.cc View 1 chunk +16 lines, -5 lines 0 comments Download
M chromeos/dbus/easy_unlock_client.h View 2 chunks +40 lines, -66 lines 0 comments Download
M chromeos/dbus/easy_unlock_client.cc View 5 chunks +22 lines, -21 lines 0 comments Download
M chromeos/dbus/fake_easy_unlock_client.h View 1 chunk +11 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_easy_unlock_client.cc View 3 chunks +22 lines, -13 lines 0 comments Download
M chromeos/dbus/fake_easy_unlock_client_unittest.cc View 2 chunks +11 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of Minor cleanup in EasyUnlockClient
6 years, 3 months ago (2014-09-16 01:46:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577443004/1
6 years, 3 months ago (2014-09-16 01:48:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as a47635efe35bdf05438974eb6cc66f8a102ad7c1
6 years, 3 months ago (2014-09-16 01:52:08 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 01:53:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b90decf7bb94f829c52601e284566e881f3774bb
Cr-Commit-Position: refs/heads/master@{#294968}

Powered by Google App Engine
This is Rietveld 408576698