Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 577403002: Revert of Third attempt to land change to remove NativeViewportService and (Closed)

Created:
6 years, 3 months ago by Dan Beam
Modified:
6 years, 3 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Third attempt to land change to remove NativeViewportService and (patchset #2 id:20001 of https://codereview.chromium.org/578353002/) Reason for revert: all these tests are timing out on Win7 Tests (dbg)(4):mojo_view_manager_unittests - https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(4)/builds/28279 ViewManagerTest.CantAccessChildrenOfEmbeddedView ViewManagerTest.SecondEmbedRoot_Service ViewManagerTest.EmbedWithSameViewId2 ViewManagerTest.EmbedWithSameViewId ViewManagerTest.ViewsRemovedWhenEmbedding ViewManagerTest.CantGetViewTreeOfOtherRoots ViewManagerTest.SetViewVisibilityNotifications ViewManagerTest.CreateView ViewManagerTest.ViewHierarchyChangedAddingKnownToUnknown ViewManagerTest.GetViewTree ViewManagerTest.ViewHierarchyChangedViews ViewManagerTest.ReuseDeletedViewId ViewManagerTest.AddViewWithNoChange ViewManagerTest.ReorderView ViewManagerTest.SetViewVisibility ViewManagerTest.CantModifyChildrenOfEmbeddedView ViewManagerTest.OnViewInput ViewManagerTest.CantMoveViewsFromOtherRoot ViewManagerTest.TwoClientsGetDifferentConnectionIds ViewManagerTest.SetViewBounds Original issue's description: > Third attempt to land change to remove NativeViewportService and > ViewManager from mojo_shell. > > Original cl was https://codereview.chromium.org/477923004/ > > BUG= > TBR=ben@chromium.org > > Committed: https://crrev.com/9b5afe9fda3e59c856cbfc43367c2719df676af0 > Cr-Commit-Position: refs/heads/master@{#295537} TBR=davemoore@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8bd80a65ba6ce9a9644bb1c9e8218857cb039dfb Cr-Commit-Position: refs/heads/master@{#295568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -268 lines) Patch
M mojo/aura/aura_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo.gyp View 10 chunks +37 lines, -14 lines 0 comments Download
M mojo/mojo_examples.gypi View 5 chunks +5 lines, -1 line 0 comments Download
M mojo/mojo_services.gypi View 11 chunks +13 lines, -36 lines 0 comments Download
M mojo/services/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/services/html_viewer/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M mojo/services/native_viewport/BUILD.gn View 3 chunks +10 lines, -16 lines 0 comments Download
M mojo/services/native_viewport/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/services/native_viewport/main.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/BUILD.gn View 1 chunk +8 lines, -7 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 3 chunks +5 lines, -11 lines 0 comments Download
M mojo/services/view_manager/ids.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 4 chunks +29 lines, -5 lines 0 comments Download
M mojo/shell/context.cc View 4 chunks +25 lines, -5 lines 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 3 chunks +16 lines, -14 lines 0 comments Download
M mojo/shell/in_process_dynamic_service_runner.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Third attempt to land change to remove NativeViewportService and
6 years, 3 months ago (2014-09-18 21:46:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/577403002/1
6 years, 3 months ago (2014-09-18 21:48:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2e3e6ce4b05532dfd882675f1ba1c2acabfc18ed
6 years, 3 months ago (2014-09-18 21:53:56 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 21:55:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bd80a65ba6ce9a9644bb1c9e8218857cb039dfb
Cr-Commit-Position: refs/heads/master@{#295568}

Powered by Google App Engine
This is Rietveld 408576698