Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 577383002: Folds ui/keyboard/webui/BUILD.gn into ui/keyboard/BUILD.gn (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Folds ui/keyboard/webui/BUILD.gn into ui/keyboard/BUILD.gn The two directories depend on each other, so there isn't much point in having separate BUILD.gn files. BUG=408651 TEST=none R=brettw@chromium.org Committed: https://crrev.com/c195a24495c12ec777d45539ece8444961002639 Cr-Commit-Position: refs/heads/master@{#295607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -47 lines) Patch
M ui/keyboard/BUILD.gn View 4 chunks +18 lines, -5 lines 0 comments Download
D ui/keyboard/webui/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
6 years, 3 months ago (2014-09-18 20:37:57 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-09-18 22:09:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/577383002/1
6 years, 3 months ago (2014-09-18 22:13:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as e8617f102ad93b3f32d66f0488f97729400d70e6
6 years, 3 months ago (2014-09-18 23:46:28 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 23:47:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c195a24495c12ec777d45539ece8444961002639
Cr-Commit-Position: refs/heads/master@{#295607}

Powered by Google App Engine
This is Rietveld 408576698