[Android] Expose GetPendingEntry from NavigationController

[Android] Expose GetPendingEntry from NavigationController

- Expose GetPendingEntry to the public Java layer for Android

BUG=385490
Committed: https://crrev.com/b316e9276bb4469277850272e3b2057465b063a1
Cr-Commit-Position: refs/heads/master@{#295809}

[David Trainor- moved to gerrit, 2014-09-18 20:01:31]

dtrainor@chromium.org changed reviewers:
+ tedchoc@chromium.org

[David Trainor- moved to gerrit, 2014-09-18 20:01:31]

ptal

[Ted C, 2014-09-18 20:29:06]

https://codereview.chromium.org/577353002/diff/1/content/browser/frame_host/n...
File content/browser/frame_host/navigation_controller_android.cc (right):

https://codereview.chromium.org/577353002/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_android.cc:30: if (!entry)
I don't think we should support NULL entries.  That should be handled in the
pending entry code.

https://codereview.chromium.org/577353002/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_android.cc:49: obj,
wha?  Why is this method not static?  Why was it not static before?

https://codereview.chromium.org/577353002/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_android.cc:65: if
(j_entry.is_null())
would be able to remove this check here based on above comment.

https://codereview.chromium.org/577353002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java
(right):

https://codereview.chromium.org/577353002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java:184:
private void addToNavigationHistory(Object history, Object navigationEntry) {
you can has make these static plz?

[David Trainor- moved to gerrit, 2014-09-18 21:06:24]

staticz

https://codereview.chromium.org/577353002/diff/1/content/browser/frame_host/n...
File content/browser/frame_host/navigation_controller_android.cc (right):

https://codereview.chromium.org/577353002/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_android.cc:30: if (!entry)
On 2014/09/18 20:29:06, Ted C wrote:
> I don't think we should support NULL entries.  That should be handled in the
> pending entry code.

Done.

https://codereview.chromium.org/577353002/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_android.cc:49: obj,
On 2014/09/18 20:29:06, Ted C wrote:
> wha?  Why is this method not static?  Why was it not static before?

hah good question!

https://codereview.chromium.org/577353002/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_android.cc:65: if
(j_entry.is_null())
On 2014/09/18 20:29:06, Ted C wrote:
> would be able to remove this check here based on above comment.

Done.

https://codereview.chromium.org/577353002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java
(right):

https://codereview.chromium.org/577353002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java:184:
private void addToNavigationHistory(Object history, Object navigationEntry) {
On 2014/09/18 20:29:06, Ted C wrote:
> you can has make these static plz?

Done.

[Ted C, 2014-09-18 21:08:42]

lgtm

[David Trainor- moved to gerrit, 2014-09-18 21:50:03]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2014-09-18 21:51:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/577353002/20001

[commit-bot: I haz the power, 2014-09-18 22:07:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 22:07:44]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[David Trainor- moved to gerrit, 2014-09-19 17:33:59]

dtrainor@chromium.org changed reviewers:
+ nasko@chromium.org

[David Trainor- moved to gerrit, 2014-09-19 17:33:59]

nasko@: ptal at navigation_controller_android.* thanks!

[(Do not use) nasko, 2014-09-19 22:08:15]

nasko@google.com changed reviewers:
+ nasko@google.com

[(Do not use) nasko, 2014-09-19 22:08:15]

LGTM

[David Trainor- moved to gerrit, 2014-09-19 22:16:48]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:17:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/577353002/20001

[commit-bot: I haz the power, 2014-09-19 22:37:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:37:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ted C, 2014-09-19 22:42:49]

On 2014/09/19 22:37:50, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

@nasko, looks like you used your google.com account so I don't think that has
the OWNER bit checked.

[nasko, 2014-09-19 23:15:54]

LGTM from @chromium.org this time.

[David Trainor- moved to gerrit, 2014-09-19 23:22:41]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2014-09-19 23:23:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/577353002/20001

[commit-bot: I haz the power, 2014-09-19 23:31:03]

Committed patchset #2 (id:20001) as 046d3e30adb3a21d45dbf76fd5be1948b41bde11

[commit-bot: I haz the power, 2014-09-19 23:31:52]

Patchset 2 (id:??) landed as
https://crrev.com/b316e9276bb4469277850272e3b2057465b063a1
Cr-Commit-Position: refs/heads/master@{#295809}