Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 577283003: Simplify fallback-handling for SVG_PAINTTYPE_URI_* (Closed)

Created:
6 years, 3 months ago by fs
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Simplify fallback-handling for SVG_PAINTTYPE_URI_* De-duplicate some of the logic for determining a fallback for a non-existant url(...). This also fixes the case where a SVGResources object is available, but the fallback is "none". BUG=415622 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
A LayoutTests/svg/custom/fill-fallback-none-3.html View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/fill-fallback-none-3-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 1 chunk +9 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
(The unified diff is the more readable one...)
6 years, 3 months ago (2014-09-18 17:08:47 UTC) #2
pdr.
On 2014/09/18 17:08:47, fs wrote: > (The unified diff is the more readable one...) LGTM
6 years, 3 months ago (2014-09-18 18:08:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577283003/1
6 years, 3 months ago (2014-09-18 18:09:51 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:15:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182253

Powered by Google App Engine
This is Rietveld 408576698