Issue 577273002: [arm64] cleanup heap numbers detection

Issue 577273002: [arm64] cleanup heap numbers detection (Closed)

Created:
6 years, 3 months ago by vincent.belliard

Modified:
6 years, 3 months ago

Reviewers:
Benedikt Meurer, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[arm64] cleanup heap numbers detection Make heap numbers detection more consistent on arm64. All the tested benchmarks (octane2, kraken, sunspider, v8-v4 and lua) are unchanged (a57 and a53). R=ulan@chromium.org, bmeurer@chromium.org BUG=

Patch Set 1 #

Total comments: 3

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -138 lines)			Patch
M	src/arm64/code-stubs-arm64.cc	View	13 chunks	+30 lines, -42 lines	3 comments	Download
M	src/arm64/full-codegen-arm64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm64/lithium-arm64.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/arm64/lithium-arm64.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm64/lithium-codegen-arm64.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	12 chunks	+33 lines, -29 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.h	View	2 chunks	+9 lines, -13 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.cc	View	6 chunks	+33 lines, -48 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://codereview.chromium.org/577273002/diff/1/src/arm64/code-stubs-arm64.cc File src/arm64/code-stubs-arm64.cc (right): https://codereview.chromium.org/577273002/diff/1/src/arm64/code-stubs-arm64.cc#newcode230 src/arm64/code-stubs-arm64.cc:230: __ JumpIfObjectType(right, right_type, right_type, HEAP_NUMBER_TYPE, Forgot to replace ...

6 years, 3 months ago (2014-09-24 08:21:41 UTC) #2

vincent.belliard

https://codereview.chromium.org/577273002/diff/1/src/arm64/code-stubs-arm64.cc File src/arm64/code-stubs-arm64.cc (right): https://codereview.chromium.org/577273002/diff/1/src/arm64/code-stubs-arm64.cc#newcode230 src/arm64/code-stubs-arm64.cc:230: __ JumpIfObjectType(right, right_type, right_type, HEAP_NUMBER_TYPE, We needs right_type when ...

6 years, 3 months ago (2014-09-24 08:25:42 UTC) #3

ulan

6 years, 3 months ago (2014-09-24 08:37:04 UTC) #4

https://codereview.chromium.org/577273002/diff/1/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (right):

https://codereview.chromium.org/577273002/diff/1/src/arm64/code-stubs-arm64.c...
src/arm64/code-stubs-arm64.cc:230: __ JumpIfObjectType(right, right_type,
right_type, HEAP_NUMBER_TYPE,
On 2014/09/24 08:25:41, vincent.belliard wrote:
> We needs right_type when it's not a heap number. Using JumpIfHeapNumber would
> load the type once and a second time if it's not a heap number.
I see, thanks for explaining.

Expand Messages | Collapse Messages