Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 577243002: update to accommodate latest clang in chrome toolchain (Closed)

Created:
6 years, 3 months ago by caryclark
Modified:
6 years, 3 months ago
Reviewers:
reed, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

update to accommodate latest clang in chrome toolchain remove asserts for null pointers to references change var args signature to pointer instead of array R=reed,mtklein Committed: https://skia.googlesource.com/skia/+/a10742c69ce47d346e3cf23e7be909c9f29b401e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M include/core/SkRect.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/views/SkOSMenu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRect.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M src/core/SkScan_Path.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkViewPriv.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
caryclark
6 years, 3 months ago (2014-09-18 14:04:34 UTC) #1
mtklein
lgtm
6 years, 3 months ago (2014-09-18 14:05:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577243002/1
6 years, 3 months ago (2014-09-18 14:06:52 UTC) #4
commit-bot: I haz the power
Presubmit check for 577243002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 3 months ago (2014-09-18 14:06:57 UTC) #6
reed1
lgtm
6 years, 3 months ago (2014-09-18 17:28:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577243002/1
6 years, 3 months ago (2014-09-18 17:28:52 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:00:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as a10742c69ce47d346e3cf23e7be909c9f29b401e

Powered by Google App Engine
This is Rietveld 408576698