Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 577193002: mojo: Add a runloop utility in python (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Add a runloop utility in python This is necessary to be able to use async operation on handles. This is a reland of https://codereview.chromium.org/552783004 after the build dependency issue has been fixed. R=sdefresne@chromium.org BUG=415485 Committed: https://crrev.com/b2309d92488dad238e897214a47711ff0e8e379c Cr-Commit-Position: refs/heads/master@{#295451}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -0 lines) Patch
M mojo/mojo.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/python/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
A mojo/public/python/mojo/c_environment.pxd View 1 1 chunk +30 lines, -0 lines 0 comments Download
M mojo/public/python/mojo/system.pyx View 2 chunks +31 lines, -0 lines 0 comments Download
A mojo/public/python/src/python_system_helper.h View 1 chunk +22 lines, -0 lines 0 comments Download
A mojo/public/python/src/python_system_helper.cc View 1 chunk +79 lines, -0 lines 0 comments Download
A mojo/python/tests/runloop_unittest.py View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/cython/rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
qsr
6 years, 3 months ago (2014-09-18 08:47:45 UTC) #1
sdefresne
RS LGTM https://codereview.chromium.org/577193002/diff/1/mojo/public/python/mojo/c_environment.pxd File mojo/public/python/mojo/c_environment.pxd (right): https://codereview.chromium.org/577193002/diff/1/mojo/public/python/mojo/c_environment.pxd#newcode13 mojo/public/python/mojo/c_environment.pxd:13: CClosure(CRunnable) nit: where is CRunnable declared?
6 years, 3 months ago (2014-09-18 08:49:43 UTC) #2
qsr
https://codereview.chromium.org/577193002/diff/1/mojo/public/python/mojo/c_environment.pxd File mojo/public/python/mojo/c_environment.pxd (right): https://codereview.chromium.org/577193002/diff/1/mojo/public/python/mojo/c_environment.pxd#newcode13 mojo/public/python/mojo/c_environment.pxd:13: CClosure(CRunnable) On 2014/09/18 08:49:43, sdefresne wrote: > nit: where ...
6 years, 3 months ago (2014-09-18 08:53:28 UTC) #3
sdefresne
Still LGTM
6 years, 3 months ago (2014-09-18 09:10:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577193002/20001
6 years, 3 months ago (2014-09-18 10:33:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0fa61f5ee11a29d6f9d6c06faca020e8adc3ba4c
6 years, 3 months ago (2014-09-18 11:07:08 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 11:07:42 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b2309d92488dad238e897214a47711ff0e8e379c
Cr-Commit-Position: refs/heads/master@{#295451}

Powered by Google App Engine
This is Rietveld 408576698