Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: test/cctest/compiler/test-run-properties.cc

Issue 577163003: Fix float truncations in typed array tests. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-run-properties.cc
diff --git a/test/cctest/compiler/test-run-properties.cc b/test/cctest/compiler/test-run-properties.cc
index a76b0629659ef3a5384ef5cef9850fab891dad01..3e95faea4641c7dbb8f006ef99685bac1e9e1652 100644
--- a/test/cctest/compiler/test-run-properties.cc
+++ b/test/cctest/compiler/test-run-properties.cc
@@ -47,8 +47,8 @@ static void TypedArrayLoadHelper(const char* array_type) {
CompilationInfo::kContextSpecializing | CompilationInfo::kTypingEnabled);
for (size_t i = 0; i < arraysize(kValues); ++i) {
for (size_t j = 0; j < arraysize(kValues); ++j) {
- U value_a = static_cast<U>(kValues[i]);
- U value_b = static_cast<U>(kValues[j]);
+ volatile U value_a = static_cast<volatile U>(kValues[i]);
+ volatile U value_b = static_cast<volatile U>(kValues[j]);
double expected =
static_cast<double>(value_a) + static_cast<double>(value_b);
T.CheckCall(T.Val(expected), T.Val(static_cast<double>(i)),
@@ -116,8 +116,8 @@ static void TypedArrayStoreHelper(const char* array_type) {
CompilationInfo::kContextSpecializing | CompilationInfo::kTypingEnabled);
for (size_t i = 0; i < arraysize(kValues); ++i) {
for (size_t j = 0; j < arraysize(kValues); ++j) {
- U value_a = static_cast<U>(kValues[i]);
- U value_b = static_cast<U>(kValues[j]);
+ volatile U value_a = static_cast<volatile U>(kValues[i]);
+ volatile U value_b = static_cast<volatile U>(kValues[j]);
double expected =
static_cast<double>(value_a) + static_cast<double>(value_b);
T.CheckCall(T.Val(expected), T.Val(static_cast<double>(i)),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698