hide deviceproperties, prepare the way for surfaceprops

hide deviceproperties, prepare the way for surfaceprops

BUG=skia:
NOTRY=True

Committed: https://skia.googlesource.com/skia/+/e010f1c2a0e6fe9cbaa73be01c7d878308b5166c

[reed1, 2014-09-17 14:56:29]

reed@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2014-09-17 15:09:32]

lgtm with the proviso that the vBGR test is re-instated as soon as possible,.

https://codereview.chromium.org/577023002/diff/1/gm/deviceproperties.cpp
File gm/deviceproperties.cpp (left):

https://codereview.chromium.org/577023002/diff/1/gm/deviceproperties.cpp#oldc...
gm/deviceproperties.cpp:45: SkDeviceProperties::Geometry::kBGR_Layout),
This is kinda the point of this particular GM, which is to test that vBGR
subpixel geometry does what we expect. We don't have anywhere else where this is
tested. If we remove this, we need to be sure to re-create a test like this as
soon as possible after getting this sort of thing working on SkSurface. Can we
open a bug to track this?

[bungeman-skia, 2014-09-17 15:09:35]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-09-17 15:10:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/577023002/1

[commit-bot: I haz the power, 2014-09-17 15:16:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-17 15:16:38]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86_64-Release-Trybo...)

[reed1, 2014-09-17 15:37:14]

https://codereview.chromium.org/577023002/diff/1/gm/deviceproperties.cpp
File gm/deviceproperties.cpp (left):

https://codereview.chromium.org/577023002/diff/1/gm/deviceproperties.cpp#oldc...
gm/deviceproperties.cpp:45: SkDeviceProperties::Geometry::kBGR_Layout),
On 2014/09/17 15:09:32, bungeman1 wrote:
> This is kinda the point of this particular GM, which is to test that vBGR
> subpixel geometry does what we expect. We don't have anywhere else where this
is
> tested. If we remove this, we need to be sure to re-create a test like this as
> soon as possible after getting this sort of thing working on SkSurface. Can we
> open a bug to track this?

https://code.google.com/p/skia/issues/detail?id=2945

[reed1, 2014-09-17 15:37:20]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-09-17 15:37:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/577023002/20001

[reed1, 2014-09-17 17:49:15]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-09-17 17:49:21]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-09-17 17:49:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/577023002/20001

[commit-bot: I haz the power, 2014-09-17 17:49:42]

Committed patchset #2 (id:20001) as e010f1c2a0e6fe9cbaa73be01c7d878308b5166c