Componentize NativeAppWindowViews

components/native_app_window.gypi

Index: components/native_app_window.gypi
diff --git a/components/crx_file.gypi b/components/native_app_window.gypi
similarity index 62%
copy from components/crx_file.gypi
copy to components/native_app_window.gypi
index 036550d39592ffcf9722d500d1f1e6349065009d..f6a719fe2e36af5cf0f40b8833dfec29d0bf1322 100644
--- a/components/crx_file.gypi
+++ b/components/native_app_window.gypi
@@ -1,24 +1,22 @@
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
-
 {
   'targets': [
     {
-      'target_name': 'crx_file',
+      'target_name': 'native_app_window',
       'type': 'static_library',
       'dependencies': [
         '../base/base.gyp:base',
+        '../skia/skia.gyp:skia',
+        '../ui/views/views.gyp:views',

[tapted, 2014/09/18 00:29:33]

I would add

        '../content/content.gyp:content_browser',
        '../extensions/extensions.gyp:extensions_browser',
        '../extensions/extensions.gyp:extensions_common',

They're the major ones it would be good to document.

I think if we could make this a real component instead of a static_library, it
would also need gfx.gyp:gfx and (conditionally) aura.gyp:aura, and probably some
other things. (pretty sure a proper component is still the goal, but it's
blocked on getting extensions a component first)

In the meantime you can run something like

gn gen out/gn_Debug && gn check out/gn_Debug //components/native_app_window

and it will list direct header dependencies that are missing. (and I've seen
patches going by to make the gn build `gn check` clean, so this will probably be
needed anyway unless you add `check_includes = false` to a BUILD.gn).

       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
-        'crx_file/constants.h',
-        'crx_file/crx_file.cc',
-        'crx_file/crx_file.h',
-        'crx_file/id_util.cc',
-        'crx_file/id_util.h',
+        'native_app_window/native_app_window_views.cc',
+        'native_app_window/native_app_window_views.h',
       ],
     },
   ],