Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 576853003: Oilpan: have ScriptStreamingTest correctly trace its PendingScript. (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: have ScriptStreamingTest correctly trace its PendingScript. As testing::Test is not on the heap, accommodate Oilpan by wrapping up ScriptStreamingTest's PendingScript (a part object containing a Member) inside an object that is on the heap & use a Persistent to refer to it from ScriptStreamingTest. R=ager BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -19 lines) Patch
M Source/bindings/core/v8/ScriptStreamerTest.cpp View 13 chunks +52 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
sof
Please take a look.
6 years, 3 months ago (2014-09-16 21:34:06 UTC) #1
Mads Ager (chromium)
LGTM
6 years, 3 months ago (2014-09-17 05:08:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576853003/1
6 years, 3 months ago (2014-09-17 05:09:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/15339)
6 years, 3 months ago (2014-09-17 05:18:41 UTC) #7
sof
Ah, needs bindings owner approval. jl, could you have a look, please? :)
6 years, 3 months ago (2014-09-17 05:49:19 UTC) #8
Jens Widell
On 2014/09/17 05:49:19, sof wrote: > Ah, needs bindings owner approval. jl, could you have ...
6 years, 3 months ago (2014-09-17 05:56:20 UTC) #9
Jens Widell
On 2014/09/17 05:56:20, Jens Widell wrote: > On 2014/09/17 05:49:19, sof wrote: > > Ah, ...
6 years, 3 months ago (2014-09-17 05:56:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576853003/1
6 years, 3 months ago (2014-09-17 05:57:49 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 182136
6 years, 3 months ago (2014-09-17 06:03:43 UTC) #13
haraken
6 years, 3 months ago (2014-09-20 08:00:18 UTC) #14
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698