Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 576823003: Merge two Notification constructors, increase priority of low-battery notification. (Closed)

Created:
6 years, 3 months ago by Peter Beverloo
Modified:
6 years, 3 months ago
CC:
chromium-reviews, derat+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Merge two Notification constructors, increase priority of low-battery notification. BUG= Committed: https://crrev.com/a554b2a3fa4cce3596c48641dd17eeac02517d48 Cr-Commit-Position: refs/heads/master@{#295287}

Patch Set 1 #

Patch Set 2 : Address a TODO while I'm here #

Patch Set 3 : Wrap kNotificationOriginUrl in GURL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -37 lines) Patch
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/browser/notifications/notification.h View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/notifications/notification.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Peter Beverloo
This increases verbosity at the two construction sites a little bit, but will make the ...
6 years, 3 months ago (2014-09-16 20:23:08 UTC) #2
Jun Mukai
lgtm, I've forgotten about that TODO... Thanks for the finding!
6 years, 3 months ago (2014-09-16 20:36:15 UTC) #3
dewittj
lgtm
6 years, 3 months ago (2014-09-16 21:00:15 UTC) #4
Peter Beverloo
nkostylev@chromium.org: Please review changes in //chrome/chromeos/.
6 years, 3 months ago (2014-09-17 13:29:31 UTC) #6
Nikita (slow)
lgtm
6 years, 3 months ago (2014-09-17 15:03:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576823003/40001
6 years, 3 months ago (2014-09-17 16:12:28 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 28279df559585185b6e53e00afb747920f56d85a
6 years, 3 months ago (2014-09-17 16:42:58 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 16:43:41 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a554b2a3fa4cce3596c48641dd17eeac02517d48
Cr-Commit-Position: refs/heads/master@{#295287}

Powered by Google App Engine
This is Rietveld 408576698