Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 576823002: Added helper function to log CloudPrint.ServiceUtilityProcessHostEvent histogram. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added helper function to log CloudPrint.ServiceUtilityProcessHostEvent histogram. Committed: https://crrev.com/f8fb586501240d5bec93fd494b18c96118b30ca6 Cr-Commit-Position: refs/heads/master@{#295118}

Patch Set 1 #

Patch Set 2 : Tue Sep 16 10:49:45 PDT 2014 #

Patch Set 3 : Tue Sep 16 10:58:45 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -36 lines) Patch
M chrome/service/service_utility_process_host.cc View 1 2 13 chunks +20 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-09-16 17:48:39 UTC) #2
Alexei Svitkine (slow)
LGTM, thanks - this should be a good saving in binary size.
6 years, 3 months ago (2014-09-16 17:54:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576823002/40001
6 years, 3 months ago (2014-09-16 18:00:27 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as de28de559575fcc77063875512677b2f8f0d2e3f
6 years, 3 months ago (2014-09-16 19:12:11 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 19:14:08 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f8fb586501240d5bec93fd494b18c96118b30ca6
Cr-Commit-Position: refs/heads/master@{#295118}

Powered by Google App Engine
This is Rietveld 408576698