Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 576733002: Configure d8 & cctest to suppress Windows error dialogs. (Closed)

Created:
6 years, 3 months ago by sigurds
Modified:
6 years, 3 months ago
Reviewers:
marja
CC:
v8-dev, Michael Achenbach
Project:
v8
Visibility:
Public.

Description

This is a reland of issue 563813002: https://codereview.chromium.org/575473002/ This time with additional include headers and MSVC specific guards. Previously, only V8 Win32 - nosnap - shared failed: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/2916 R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M src/d8.cc View 2 chunks +21 lines, -1 line 0 comments Download
M test/cctest/cctest.cc View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sigurds
PTAL. Not the some of the trybots are red because they applied the patch on ...
6 years, 3 months ago (2014-09-17 14:12:54 UTC) #2
marja
lgtm
6 years, 3 months ago (2014-09-17 14:15:42 UTC) #3
sigurds
6 years, 3 months ago (2014-09-17 14:20:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698