Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h |
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h |
index 567cac47ef0765afe2bf7c296cb3f6184575854e..3ee6cd2a3636c81742b2f31ab5251bdd4748cd71 100644 |
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h |
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h |
@@ -125,16 +125,26 @@ class SafeBrowsingBlockingPage : public content::InterstitialPageDelegate { |
FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageTest, |
MalwareReportsToggling); |
- enum BlockingPageEvent { |
+ // These enums are used for histograms. Don't reorder, delete, or insert |
+ // elements. New elements should be added before MAX_ACTION only. |
+ enum Decision { |
SHOW, |
PROCEED, |
DONT_PROCEED, |
+ PROCEEDING_DISABLED, |
+ MAX_DECISION |
+ }; |
+ enum Interaction { |
SHOW_ADVANCED, |
+ SHOW_PRIVACY_POLICY, |
+ SHOW_DIAGNOSTIC, |
+ SHOW_LEARN_MORE, |
+ MAX_INTERACTION |
}; |
- // Records a user action for this interstitial, using the form |
- // SBInterstitial[Phishing|Malware|Multiple][Show|Proceed|DontProceed]. |
- void RecordUserAction(BlockingPageEvent event); |
+ // Record a user decision or interaction to the appropriate UMA histogram. |
+ void RecordUserDecision(Decision decision); |
+ void RecordUserInteraction(Interaction interaction); |
// Used to query the HistoryService to see if the URL is in history. For UMA. |
void OnGotHistoryCount(bool success, int num_visits, base::Time first_visit); |