Mac: Ignore sheets when deciding whether to dismiss a browser action popup.

chrome/browser/ui/cocoa/base_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_nsobject.h"
@@ skipping 223 matching lines @@
   [self closeCleanup];
   [super close];
 }
 
 // The controller is the delegate of the window so it receives did resign key
 // notifications. When key is resigned mirror Windows behavior and close the
 // window.
 - (void)windowDidResignKey:(NSNotification*)notification {
   NSWindow* window = [self window];
   DCHECK_EQ([notification object], window);
-  if ([window isVisible] && [self shouldCloseOnResignKey]) {
-    // If the window isn't visible, it is already closed, and this notification
-    // has been sent as part of the closing operation, so no need to close.
+
+  // If the window isn't visible, it is already closed, and this notification
+  // has been sent as part of the closing operation, so no need to close.
+  if (![window isVisible])
+    return;
+
+  // Don't close when explicily disabled, or if there's an attached sheet (e.g.
+  // Open File dialog).
+  if ([self shouldCloseOnResignKey] && ![window attachedSheet]) {
     [self close];
-  } else if ([window isVisible]) {
-    // The bubble should not receive key events when it is no longer key window,
-    // so disable sharing parent key state. Share parent key state is only used
-    // to enable the close/minimize/maximize buttons of the parent window when
-    // the bubble has key state, so disabling it here is safe.
-    InfoBubbleWindow* bubbleWindow =
-        base::mac::ObjCCastStrict<InfoBubbleWindow>([self window]);
-    [bubbleWindow setAllowShareParentKeyState:NO];
+    return;
   }
+
+  // The bubble should not receive key events when it is no longer key window,
+  // so disable sharing parent key state. Share parent key state is only used
+  // to enable the close/minimize/maximize buttons of the parent window when
+  // the bubble has key state, so disabling it here is safe.
+  InfoBubbleWindow* bubbleWindow =
+      base::mac::ObjCCastStrict<InfoBubbleWindow>([self window]);
+  [bubbleWindow setAllowShareParentKeyState:NO];
 }
 
 - (void)windowDidBecomeKey:(NSNotification*)notification {
   // Re-enable share parent key state to make sure the close/minimize/maximize
   // buttons of the parent window are active.
   InfoBubbleWindow* bubbleWindow =
       base::mac::ObjCCastStrict<InfoBubbleWindow>([self window]);
   [bubbleWindow setAllowShareParentKeyState:YES];
 }
 
-// Since the bubble shares first responder with its parent window, set
-// event handlers to dismiss the bubble when it would normally lose key
-// state.
+// Since the bubble shares first responder with its parent window, set event
+// handlers to dismiss the bubble when it would normally lose key state.
+// Events on sheets are ignored: this assumes the sheet belongs to the bubble
+// since, to affect a sheet on a different window, the bubble would also lose
+// key status in -[NSWindowDelegate windowDidResignKey:]. This keeps the logic
+// simple, since -[NSWindow attachedSheet] returns nil while the sheet is still
+// closing.
 - (void)registerKeyStateEventTap {
   // Parent key state sharing is only avaiable on 10.7+.
   if (!base::mac::IsOSLionOrLater())
     return;
 
   NSWindow* window = self.window;
   NSNotification* note =
       [NSNotification notificationWithName:NSWindowDidResignKeyNotification
                                     object:window];
 
   // The eventTap_ catches clicks within the application that are outside the
   // window.
   eventTap_ = [NSEvent
       addLocalMonitorForEventsMatchingMask:NSLeftMouseDownMask |
                                            NSRightMouseDownMask
       handler:^NSEvent* (NSEvent* event) {
-          if (event.window != window) {
+          if ([event window] != window && ![[event window] isSheet]) {
             // Do it right now, because if this event is right mouse event,
             // it may pop up a menu. windowDidResignKey: will not run until
             // the menu is closed.
             if ([self respondsToSelector:@selector(windowDidResignKey:)]) {
               [self windowDidResignKey:note];
             }
           }
           return event;
       }];
 
   // The resignationObserver_ watches for when a window resigns key state,
   // meaning the key window has changed and the bubble should be dismissed.
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
   resignationObserver_ =
       [center addObserverForName:NSWindowDidResignKeyNotification
                           object:nil
                            queue:[NSOperationQueue mainQueue]
                       usingBlock:^(NSNotification* notif) {
-                          [self windowDidResignKey:note];
+                          if (![[notif object] isSheet])
+                            [self windowDidResignKey:note];
                       }];
 }
 
 // By implementing this, ESC causes the window to go away.
 - (IBAction)cancel:(id)sender {
   // This is not a "real" cancel as potential changes to the radio group are not
   // undone. That's ok.
   [self close];
 }
 
@@ skipping 52 matching lines @@
 
 - (void)activateTabWithContents:(content::WebContents*)newContents
                previousContents:(content::WebContents*)oldContents
                         atIndex:(NSInteger)index
                          reason:(int)reason {
   // The user switched tabs; close.
   [self close];
 }
 
 @end  // BaseBubbleController