content/common/gpu/media/rendering_helper.cc - Issue 57663002: Add VDA decode time test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/rendering_helper.cc

Issue 57663002: Add VDA decode time test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address owenlin's comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/rendering_helper.cc

diff --git a/content/common/gpu/media/rendering_helper.cc b/content/common/gpu/media/rendering_helper.cc

index b0f540ea866def2bc102b5bd609d4137df593be8..3b65d7406e16cbde9c1f826ae38eb0ffa3c12440 100644

--- a/content/common/gpu/media/rendering_helper.cc

+++ b/content/common/gpu/media/rendering_helper.cc

@@ -81,7 +81,8 @@ std::string GLContextStubWithExtensions::GetExtensions() {

namespace content {

-RenderingHelperParams::RenderingHelperParams() {}

+RenderingHelperParams::RenderingHelperParams()

+ : num_windows(1), render_as_thumbnails(false) {}

Ami GONE FROM CHROMIUM 2013/11/04 18:26:51 Why not instead make these ctor params and turn th

wuchengli 2013/11/05 06:24:15 Making all the members to ctor introduces more cod

RenderingHelperParams::~RenderingHelperParams() {}