Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 576603002: Revert of mojo: Starting serialization for python bindings. (Closed)

Created:
6 years, 3 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 3 months ago
Reviewers:
Chris Masone, sdefresne, qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, tburkard
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of mojo: Starting serialization for python bindings. (patchset #3 id:40001 of https://codereview.chromium.org/570563002/) Reason for revert: This patch appears to be causing failures on the Linux Tests bot. http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13627 Original issue's description: > mojo: Starting serialization for python bindings. > > R=sdefresne@chromium.org,cmasone@chromium.org > > Committed: https://crrev.com/4e395c5e4c9025f187c98fb38730858b5cfdcc65 > Cr-Commit-Position: refs/heads/master@{#294846} TBR=cmasone@chromium.org,sdefresne@chromium.org,qsr@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9e3ffc5e9285de0bddd79fec4700b05da8c57a79 Cr-Commit-Position: refs/heads/master@{#294959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -535 lines) Patch
M mojo/public/python/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/python/mojo/bindings/descriptor.py View 10 chunks +64 lines, -283 lines 0 comments Download
M mojo/public/python/mojo/bindings/reflection.py View 2 chunks +1 line, -17 lines 0 comments Download
D mojo/public/python/mojo/bindings/serialization.py View 1 chunk +0 lines, -98 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_python_generator.py View 4 chunks +53 lines, -81 lines 0 comments Download
M mojo/public/tools/bindings/generators/python_templates/module.py.tmpl View 1 chunk +3 lines, -3 lines 0 comments Download
D mojo/python/tests/bindings_serialization_deserialization_unittest.py View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
acolwell GONE FROM CHROMIUM
Created Revert of mojo: Starting serialization for python bindings.
6 years, 3 months ago (2014-09-16 00:45:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576603002/1
6 years, 3 months ago (2014-09-16 00:48:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d8ddb6edcabdeeb2bc4bd7bc1e9f8964c0c6b263
6 years, 3 months ago (2014-09-16 01:10:38 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9e3ffc5e9285de0bddd79fec4700b05da8c57a79 Cr-Commit-Position: refs/heads/master@{#294959}
6 years, 3 months ago (2014-09-16 01:13:33 UTC) #4
qsr
lgtm
6 years, 3 months ago (2014-09-16 07:26:50 UTC) #5
sdefresne
6 years, 3 months ago (2014-09-16 07:52:24 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698