Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 57643007: chromium-status: tighten up the Who/When columns (Closed)

Created:
7 years, 1 month ago by vapier
Modified:
7 years, 1 month ago
Reviewers:
cmp
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

chromium-status: tighten up the Who/When columns Often times the Message field is very long (especially when multiple failures are logged in there). This forces the other two columns to get wrapped heavily. For the date, this makes the field unreadable: Sat Nov 02, 17:09 UTC Shrink the size slightly for both these fields (as we just want to scan them vertically, but otherwise focus on the Message), disable white space breaking on the date, and move the redundant timezone to the column header. BUG=chromium:314501 TEST=ran an appengine instance and checked the output TEST=`./tests/main_test.py` passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=234171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M stylesheets/style.css View 1 chunk +10 lines, -0 lines 0 comments Download
M templates/main.html View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vapier
this is the same as https://codereview.chromium.org/57013002/ but with a fixed base url, so quick lgtm ...
7 years, 1 month ago (2013-11-04 22:40:01 UTC) #1
cmp
lgtm
7 years, 1 month ago (2013-11-10 15:36:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/57643007/1
7 years, 1 month ago (2013-11-10 15:36:28 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-10 15:36:34 UTC) #4
Message was sent while issue was closed.
Change committed as 234171

Powered by Google App Engine
This is Rietveld 408576698