Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: Source/core/dom/Range.cpp

Issue 57643004: Pass RenderStyle / RenderObject by reference in more places (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase on master Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/frame/animation/AnimationBase.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999 Lars Knoll (knoll@kde.org) 2 * (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Gunnstein Lye (gunnstein@netcom.no) 3 * (C) 2000 Gunnstein Lye (gunnstein@netcom.no)
4 * (C) 2000 Frederik Holljen (frederik.holljen@hig.no) 4 * (C) 2000 Frederik Holljen (frederik.holljen@hig.no)
5 * (C) 2001 Peter Kelly (pmk@post.com) 5 * (C) 2001 Peter Kelly (pmk@post.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
7 * Copyright (C) 2011 Motorola Mobility. All rights reserved. 7 * Copyright (C) 2011 Motorola Mobility. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1843 matching lines...) Expand 10 before | Expand all | Expand 10 after
1854 if (node->isElementNode()) 1854 if (node->isElementNode())
1855 nodeSet.add(node); 1855 nodeSet.add(node);
1856 } 1856 }
1857 1857
1858 for (Node* node = firstNode(); node != stopNode; node = NodeTraversal::next( node)) { 1858 for (Node* node = firstNode(); node != stopNode; node = NodeTraversal::next( node)) {
1859 if (node->isElementNode()) { 1859 if (node->isElementNode()) {
1860 if (!nodeSet.contains(node->parentNode())) { 1860 if (!nodeSet.contains(node->parentNode())) {
1861 if (RenderBoxModelObject* renderBoxModelObject = toElement(node) ->renderBoxModelObject()) { 1861 if (RenderBoxModelObject* renderBoxModelObject = toElement(node) ->renderBoxModelObject()) {
1862 Vector<FloatQuad> elementQuads; 1862 Vector<FloatQuad> elementQuads;
1863 renderBoxModelObject->absoluteQuads(elementQuads); 1863 renderBoxModelObject->absoluteQuads(elementQuads);
1864 m_ownerDocument->adjustFloatQuadsForScrollAndAbsoluteZoom(el ementQuads, renderBoxModelObject); 1864 m_ownerDocument->adjustFloatQuadsForScrollAndAbsoluteZoom(el ementQuads, *renderBoxModelObject);
1865 1865
1866 quads.append(elementQuads); 1866 quads.append(elementQuads);
1867 } 1867 }
1868 } 1868 }
1869 } else if (node->isTextNode()) { 1869 } else if (node->isTextNode()) {
1870 if (RenderObject* renderer = toText(node)->renderer()) { 1870 if (RenderObject* renderer = toText(node)->renderer()) {
1871 RenderText* renderText = toRenderText(renderer); 1871 RenderText& renderText = toRenderText(*renderer);
1872 int startOffset = (node == startContainer) ? m_start.offset() : 0; 1872 int startOffset = (node == startContainer) ? m_start.offset() : 0;
1873 int endOffset = (node == endContainer) ? m_end.offset() : INT_MA X; 1873 int endOffset = (node == endContainer) ? m_end.offset() : INT_MA X;
1874 1874
1875 Vector<FloatQuad> textQuads; 1875 Vector<FloatQuad> textQuads;
1876 renderText->absoluteQuadsForRange(textQuads, startOffset, endOff set); 1876 renderText.absoluteQuadsForRange(textQuads, startOffset, endOffs et);
1877 m_ownerDocument->adjustFloatQuadsForScrollAndAbsoluteZoom(textQu ads, renderText); 1877 m_ownerDocument->adjustFloatQuadsForScrollAndAbsoluteZoom(textQu ads, renderText);
1878 1878
1879 quads.append(textQuads); 1879 quads.append(textQuads);
1880 } 1880 }
1881 } 1881 }
1882 } 1882 }
1883 } 1883 }
1884 1884
1885 FloatRect Range::boundingRect() const 1885 FloatRect Range::boundingRect() const
1886 { 1886 {
(...skipping 20 matching lines...) Expand all
1907 1907
1908 void showTree(const WebCore::Range* range) 1908 void showTree(const WebCore::Range* range)
1909 { 1909 {
1910 if (range && range->boundaryPointsValid()) { 1910 if (range && range->boundaryPointsValid()) {
1911 range->startContainer()->showTreeAndMark(range->startContainer(), "S", r ange->endContainer(), "E"); 1911 range->startContainer()->showTreeAndMark(range->startContainer(), "S", r ange->endContainer(), "E");
1912 fprintf(stderr, "start offset: %d, end offset: %d\n", range->startOffset (), range->endOffset()); 1912 fprintf(stderr, "start offset: %d, end offset: %d\n", range->startOffset (), range->endOffset());
1913 } 1913 }
1914 } 1914 }
1915 1915
1916 #endif 1916 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/frame/animation/AnimationBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698