Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Issue 576423002: Fix map-branches issues and add coloring for 'branch-heads', (Closed)

Created:
6 years, 3 months ago by calamity
Modified:
6 years, 2 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Fix map-branches issues and add coloring for 'branch-heads', This CL fixes some issues with map-branches: * Branches with no upstream were not being shown. * -vv from a detached HEAD would crash * GONE upstreams would crash when git cleaned up in a way that caused hash_one to fail This CL also adds a blue coloring to branches that start with 'branch-heads' for Chromium release branches. BUG=416530 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292083

Patch Set 1 #

Total comments: 2

Patch Set 2 : update man pages #

Patch Set 3 : fix url bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -16 lines) Patch
M git_map_branches.py View 1 2 7 chunks +12 lines, -4 lines 0 comments Download
M man/html/git-map-branches.html View 1 3 chunks +10 lines, -5 lines 0 comments Download
M man/man1/git-map-branches.1 View 1 3 chunks +22 lines, -7 lines 0 comments Download
M man/src/git-map-branches.txt View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
calamity
6 years, 3 months ago (2014-09-18 01:53:01 UTC) #2
iannucci
oops, sorry, lgtm. Could you add the (new) bug too? https://codereview.chromium.org/576423002/diff/1/git_map_branches.py File git_map_branches.py (right): https://codereview.chromium.org/576423002/diff/1/git_map_branches.py#newcode161 ...
6 years, 2 months ago (2014-09-23 00:42:01 UTC) #3
calamity
https://codereview.chromium.org/576423002/diff/1/git_map_branches.py File git_map_branches.py (right): https://codereview.chromium.org/576423002/diff/1/git_map_branches.py#newcode161 git_map_branches.py:161: color = Fore.BLUE On 2014/09/23 00:42:01, iannucci wrote: > ...
6 years, 2 months ago (2014-09-23 03:28:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/576423002/40001
6 years, 2 months ago (2014-09-23 03:28:38 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-23 03:30:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 292083

Powered by Google App Engine
This is Rietveld 408576698