Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 576413002: Reland Track the active ExtensionKeybindingRegistry and make it available to EventRewriter. (Closed)

Created:
6 years, 3 months ago by David Tseng
Modified:
6 years, 3 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, extensions-reviews_chromium.org, ben+aura_chromium.org, nkostylev+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, sadrul, rginda+watch_chromium.org, oshima+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Reland Track the active ExtensionKeybindingRegistry and make it available to EventRewriter. Original issue https://codereview.chromium.org/553243002/ TBR=dtseng@chromium.org BUG=410944 Committed: https://crrev.com/cfb07083d90bf28acfad745c2baea468d12bee10 Cr-Commit-Position: refs/heads/master@{#295411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -10 lines) Patch
M chrome/browser/chromeos/events/event_rewriter.cc View 3 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_commands_global_registry.h View 2 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_commands_global_registry.cc View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 2 chunks +38 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 2 chunks +19 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/keybinding/chromeos_conversions/background.js View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/keybinding/chromeos_conversions/manifest.json View 1 chunk +34 lines, -0 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aurax11.cc View 4 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576413002/1
6 years, 3 months ago (2014-09-18 03:34:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2ecd50aabb1920b3b201bafd6346393616dad995
6 years, 3 months ago (2014-09-18 04:00:41 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 04:10:11 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cfb07083d90bf28acfad745c2baea468d12bee10
Cr-Commit-Position: refs/heads/master@{#295411}

Powered by Google App Engine
This is Rietveld 408576698