Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 576343002: [Easy signin] Add method to get user info to easyUnlockPrivate (Closed)

Created:
6 years, 3 months ago by tbarzic
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Easy signin] Add method to get user info to easyUnlockPrivate The method will return the user email and whether the user's logged in, i.e. whether the app is running on signin screen. Adds an event that's triggered when the user focused on login screen changes. While here, add logic to unload the app and reset signin profile EasyUnlockService when user logs in. Create the signin service only if enable-easy-signin switch is set. BUG=401634 Committed: https://crrev.com/94208c2bd36b530f6bb6d1c94aec4127d9508642 Cr-Commit-Position: refs/heads/master@{#296120}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : missing a ResetScreenHanlder in FocusedUSerChanged #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Total comments: 2

Patch Set 14 : shutdown #

Patch Set 15 : . #

Total comments: 6

Patch Set 16 : rebase to master #

Patch Set 17 : . #

Patch Set 18 : win fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -25 lines) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h View 1 2 3 4 5 6 7 3 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +21 lines, -3 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 7 chunks +63 lines, -8 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +20 lines, -3 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +67 lines, -10 lines 0 comments Download
M chrome/browser/signin/screenlock_bridge.h View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/signin/screenlock_bridge.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 4 5 6 7 8 9 10 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/easy_unlock_private.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +31 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (5 generated)
tbarzic
6 years, 3 months ago (2014-09-17 22:36:35 UTC) #2
tbarzic
On 2014/09/17 22:36:35, tbarzic wrote: The cl I was talking about, I'll let you know ...
6 years, 3 months ago (2014-09-17 22:37:35 UTC) #3
tbarzic
ok, I think this one is more or less ready (I split some bits off ...
6 years, 3 months ago (2014-09-20 02:29:15 UTC) #4
xiyuan
lgtm https://codereview.chromium.org/576343002/diff/230001/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc File chrome/browser/signin/easy_unlock_service_signin_chromeos.cc (right): https://codereview.chromium.org/576343002/diff/230001/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc#newcode98 chrome/browser/signin/easy_unlock_service_signin_chromeos.cc:98: StopService(); dtor is pretty late. Suggest to do ...
6 years, 3 months ago (2014-09-22 17:35:33 UTC) #5
tbarzic
PTAL (also, I'll have to land https://codereview.chromium.org/583403002/ before this one) https://codereview.chromium.org/576343002/diff/230001/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc File chrome/browser/signin/easy_unlock_service_signin_chromeos.cc (right): https://codereview.chromium.org/576343002/diff/230001/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc#newcode98 ...
6 years, 3 months ago (2014-09-22 18:54:03 UTC) #6
tbarzic
+isherman for histograms +yoz for chrome/common/extensions/api/easy_unlock_private.idl
6 years, 3 months ago (2014-09-22 18:55:18 UTC) #8
Ilya Sherman
histograms lgtm
6 years, 3 months ago (2014-09-22 20:50:14 UTC) #9
Yoyo Zhou
LGTM with nits https://codereview.chromium.org/576343002/diff/270001/chrome/common/extensions/api/easy_unlock_private.idl File chrome/common/extensions/api/easy_unlock_private.idl (right): https://codereview.chromium.org/576343002/diff/270001/chrome/common/extensions/api/easy_unlock_private.idl#newcode166 chrome/common/extensions/api/easy_unlock_private.idl:166: // list for future use (on ...
6 years, 3 months ago (2014-09-22 23:29:07 UTC) #10
tbarzic
https://codereview.chromium.org/576343002/diff/270001/chrome/common/extensions/api/easy_unlock_private.idl File chrome/common/extensions/api/easy_unlock_private.idl (right): https://codereview.chromium.org/576343002/diff/270001/chrome/common/extensions/api/easy_unlock_private.idl#newcode166 chrome/common/extensions/api/easy_unlock_private.idl:166: // list for future use (on signing screen there ...
6 years, 3 months ago (2014-09-22 23:43:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/576343002/310001
6 years, 3 months ago (2014-09-22 23:56:56 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/64145)
6 years, 3 months ago (2014-09-23 00:18:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/576343002/330001
6 years, 3 months ago (2014-09-23 00:27:20 UTC) #17
commit-bot: I haz the power
Committed patchset #18 (id:330001) as 5d0a4756b27793cca8aaf4a0d4b3768c8ae84309
6 years, 3 months ago (2014-09-23 01:30:16 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 01:30:52 UTC) #19
Message was sent while issue was closed.
Patchset 18 (id:??) landed as
https://crrev.com/94208c2bd36b530f6bb6d1c94aec4127d9508642
Cr-Commit-Position: refs/heads/master@{#296120}

Powered by Google App Engine
This is Rietveld 408576698