Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart

Issue 576333002: Precompile immutable dependencies on "pub get". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart
diff --git a/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart b/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart
index 5ce8cb0de348f15a88f7cca7fa7b0a506e4b6249..684668c54c398a8191a2c94afcff3f2c55763aea 100644
--- a/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart
+++ b/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart
@@ -24,19 +24,14 @@ class TransformerCache {
return _graph.transitiveDependencies(
id.package).map((package) => package.name).toSet();
}));
- if (!changedPackages.any(snapshotDependencies.contains)) return;
+ if (!overlaps(changedPackages, snapshotDependencies)) return;
deleteEntry(_dir);
_oldTransformers = new Set();
}
String snapshotPath(Set<TransformerId> transformers) {
- var usesMutableTransformer = transformers.any((id) {
- var package = _graph.lockFile.packages[id.package];
- if (package == null) return true;
- var source = _graph.entrypoint.cache.sources[package.source];
- return source is! CachedSource;
- });
var path = p.join(_dir, "transformers.snapshot");
- if (usesMutableTransformer) {
+ if (_newTransformers != null) return path;
+ if (transformers.any((id) => _graph.isPackageMutable(id.package))) {
log.fine("Not caching mutable transformers.");
deleteEntry(_dir);
return null;

Powered by Google App Engine
This is Rietveld 408576698